feat-ISSUE-3782-PR 1/2 adding crosstables rule - zone for destination and source #3834
+914
−277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Imat00 sorry I also had to add some permissions - could you please resolve the resulting conflicts in your branch? |
should be done |
|
@Imat00 there seems to be an issue with the metadata file (test import job fails) |
Yes, currently working on it |
|
Finally! |
Kept incoming changes from remote and renamed local methods for clarity: - DisplayDestinationZones() (was DisplayDestinationZone() before) - DisplaySourceZones() (was DisplaySourceZone() before)
fixed: warnings
…e zones - changed GraphQL fragments for rule zones - renamed normalized rule fields from *zone to *zones - updated export tests for rules with multiple zones
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
management - role reporter - select - add mgm_uid
rule - recertifier - select - add is_global and rulebase_id
rule - modeller - select - add is_global and rulebase_id
rule_from/rule_to - middleware - seelct - add cl_from_relevant_for_tenant
rule_service and more add removed in select for filtered roles
changelog_rule add cl_rule_relevant_for_tenant in select for filtered roles