-
Notifications
You must be signed in to change notification settings - Fork 54
Open
Description
As debugged in lodestar ChainSafe/lodestar#8629, lodestar has to uncompress ~180 DataColumnSidecars per slot while there should only be 128
this is because the validateReceivedMessage() function being async
js-libp2p-gossipsub/src/index.ts
Line 1295 in afc85ee
| private async validateReceivedMessage ( |
for lodestar, it could/should be synced function because:
- signature policy is
StrictNoSign msgIdFnis synced https://github.com/ChainSafe/lodestar/blob/2d3601648b05c2365bbed3427434118d7e688e2b/packages/beacon-node/src/network/gossip/encoding.ts#L42- there is no
topicValidator
if we can do that, then we can detect duplicate messages more efficiently in order to send exactly 128 messages per slot and lodestar doesn't have to uncompress unnecessary messages
Metadata
Metadata
Assignees
Labels
No labels