duplicated endpoints calls deleted

Author: Chmod351

server/Service/commentService.js

@@ -7,15 +7,7 @@ const commentService = {
   createComment,
 };
 
-// get comment by id
-async function getCommentById(id) {
-  const comment = await Comment.findById(id);
-  if (comment) {
-    return comment;
-  } else {
-    return new NotFoundError(`Comment Not Found`);
-  }
-}
+
 
 // create comment
 async function createComment(userId, calification, description) {
@@ -40,7 +32,6 @@ async function getAllComment(page, size) {
 
 // delete comment by id
 async function deleteComment(commentId) {
-  await getCommentById(commentId);
   const res = await Comment.findByIdAndDelete(commentId);
   return res;
 }

server/Service/productService.js

@@ -23,7 +23,7 @@ function isValidObjectId(id) {
     return false;
   }
 }
-
+// get product by id
 async function getProductById(productId) {
   if (productId && isValidObjectId(productId)) {
     const product = await Product.findById(productId);
@@ -32,6 +32,7 @@ async function getProductById(productId) {
     throw new NotFoundError(`Product with id ${productId} Not found`);
   }
 }
+// pagination products
 
 async function getProduct(page, size) {
   // Pagination for products
@@ -51,6 +52,7 @@ async function getProduct(page, size) {
   return { products, totalPages };
 }
 
+// recomendations && categories
 async function getProductByTag(category, page, size) {
   const actualPage = parseInt(page) || 1;
   const pageSize = parseInt(size) || 8;
@@ -67,6 +69,7 @@ async function getProductByTag(category, page, size) {
   return { products, totalPages };
 }
 
+// create products
 async function createProduct(
   name,
   img,
@@ -89,13 +92,14 @@ async function createProduct(
   });
   return await newProduct.save();
 }
-
+// products by query
 async function searchProduct(query) {
   const product = await Product.find({
     name: { $regex: query, $options: 'i' },
   }).limit(40);
   return product;
 }
+// change products properties
 
 async function updateProduct(productId, newPrice, hot, newDescription) {
   const updatedProperties = {};
@@ -117,9 +121,8 @@ async function updateProduct(productId, newPrice, hot, newDescription) {
   );
   return result;
 }
-
+// delete products
 async function deleteProduct(productId) {
-  await getProductById(productId);
   return await Product.findOneAndDelete(productId);
 }
 

server/Service/purchasesService.js

@@ -13,15 +13,13 @@ const purchaseService = {
   processPayment,
 };
 
+// find purchase by id
 async function findPurchaseById(id) {
   const purchase = await Purchase.findById(id);
-  if (purchase) {
     return purchase;
-  } else {
-    throw new NotFoundError(`Purchase with id ${id} Not found`);
-  }
-}
 
+}
+// create purchases
 async function createPurchase(userId, cartId, amount, shippingAddress) {
   const purchase = new Purchase({
     userId,
@@ -32,7 +30,7 @@ async function createPurchase(userId, cartId, amount, shippingAddress) {
 
   return await purchase.save();
 }
-
+// get all purchases
 async function getAllPurchase(page, size) {
   // get a pagination with purchases instead all purchases
   const actualPage = parseInt(page) || 1;
@@ -50,11 +48,11 @@ async function getAllPurchase(page, size) {
 
   return { products, totalPages };
 }
-
+// get user purchases
 async function getUserPurchase(id) {
   return await Purchase.find({ userId: id });
 }
-
+// get monthly purchases
 async function getMonthly() {
   //show the last 2 months sales
   const date = new Date();
@@ -78,12 +76,11 @@ async function getMonthly() {
   ]);
   return income;
 }
-
+// delete purchases
 async function cleanPurchase(id) {
-  await findPurchaseById(id);
   return await Purchase.findByIdAndDelete(id);
 }
-
+// change status purchases
 async function updatePurchaseState(id, status) {
   await findPurchaseById(id);
   const newStatus = await Purchase.findOneAndUpdate(

server/Service/shopingCartService.js

@@ -9,17 +9,13 @@ const cartService = {
   getAll,
 };
 
-// get cart by id 
+// get cart by id
 async function findCartById(id) {
   const cart = await ShoppingCart.findById(id);
-  if (cart) {
-    return cart;
-  } else {
-    return new NotFoundError(`Cart Not Found`);
-  }
+  return cart;
 }
 
-// create cart 
+// create cart
 async function createCart(products, userId) {
   const newCart = new ShoppingCart({ products, userId });
   return await newCart.save();
@@ -44,15 +40,14 @@ async function getAll(page, size) {
   return { carts, totalPages };
 }
 
-// get user carts by user id 
+// get user carts by user id
 async function getUserCart(userId) {
   await userService.getUser(userId);
   return await ShoppingCart.findOne({ userId });
 }
 
 // edit user cart by id
 async function editCart(body, cartId) {
-  await findCartById(cartId);
   return await ShoppingCart.findByIdAndUpdate(
     cartId,
     {
@@ -64,7 +59,6 @@ async function editCart(body, cartId) {
 
 //delete user cart by cart id
 async function deleteCart(cartId) {
-  await findCartById(cartId);
   return await ShoppingCart.findByIdAndDelete(cartId);
 }
 

server/Service/usersService.js

@@ -52,7 +52,7 @@ async function signIn(user) {
 }
 
 async function checkLength(item, num) {
-if (item.length >= num) {
+  if (item.length >= num) {
     return true;
   } else {
     throw new BadRequestError(
@@ -71,15 +71,14 @@ async function signUp(user) {
       return obj;
     }, {});
 
-  const registeredUser = await findByEmail(filteredUser.email);
   const validatePass = await checkLength(filteredUser.password, 8);
-  if (!registeredUser && validatePass) {
+  if (validatePass) {
     const encryptPassword = await encrypt.hashPassword(filteredUser.password);
     const createUser = new User({ ...filteredUser, password: encryptPassword });
     const newUser = await createUser.save();
     return newUser;
   } else {
-    throw new BadRequestError('email already in use');
+    throw new BadRequestError('password does not match');
   }
 }