fix(bgp neighbor): Update 'update_source_loopback' property to match TF naming conventions #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ention Renamed `update_source_loopback` to `update_source_interface_loopback` in the BGP Neighbor definition. This update is reflected across documentation, examples, and codebase for consistency and clarity.
Contributor
Author
|
I made this PR per @danischm 's comment here: #317 (comment) |
danischm
approved these changes
Nov 3, 2025
ChristopherJHart
added a commit
to ChristopherJHart/terraform-iosxe-nac-iosxe
that referenced
this pull request
Nov 9, 2025
Completes the fix started in PR netascode#85 by updating the iosxe_bgp_ipv4_unicast_vrf_neighbor resource to use the update_source_interface_loopback attribute name, matching the provider changes from CiscoDevNet/terraform-provider-iosxe#329. The previous PR fixed iosxe_bgp_neighbor but missed updating the VRF neighbor resource attributes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the "
tf_name" parameter for the BGP neighbor update source interface attribute to better align with Terraform naming conventions.This change makes the attribute name more consistent with the underlying YANG path (
update-source/interface/Loopback) while adhering to expected TF naming conventions, clearly indicating that it references an interface (specifically a Loopback interface).Changes:
update_source_loopbacktoupdate_source_interface_loopbackin the BGP Neighbor definition.gen/definitions/bgp_neighbor.yaml(Lines 91-93)