fix sync issues

Author: brachy84

src/main/java/com/cleanroommc/modularui/value/sync/ModularSyncManager.java

@@ -17,10 +17,12 @@
 import net.minecraftforge.items.wrapper.PlayerMainInvWrapper;
 
 import it.unimi.dsi.fastutil.objects.Object2ObjectOpenHashMap;
+import it.unimi.dsi.fastutil.objects.ObjectOpenHashSet;
 import org.jetbrains.annotations.ApiStatus;
 
 import java.io.IOException;
 import java.util.Map;
+import java.util.Set;
 
 public class ModularSyncManager {
 
@@ -29,6 +31,9 @@ public class ModularSyncManager {
     private static final String CURSOR_KEY = makeSyncKey("cursor_slot", 255255);
 
     private final Map<String, PanelSyncManager> panelSyncManagerMap = new Object2ObjectOpenHashMap<>();
+    // A set of all panels which have been opened during the ui. May also contain closed panels.
+    // This is used to detect if
+    private final Set<String> panelHistory = new ObjectOpenHashSet<>();
     private PanelSyncManager mainPSM;
     private final ModularContainer container;
     private final CursorSlotSyncHandler cursorSlotSyncHandler = new CursorSlotSyncHandler();
@@ -88,6 +93,7 @@ public void setCursorItem(ItemStack item) {
 
     public void open(String name, PanelSyncManager syncManager) {
         this.panelSyncManagerMap.put(name, syncManager);
+        this.panelHistory.add(name);
         syncManager.initialize(name, this);
     }
 
@@ -101,7 +107,14 @@ public boolean isOpen(String panelName) {
     }
 
     public void receiveWidgetUpdate(String panelName, String mapKey, int id, PacketBuffer buf) throws IOException {
-        getPanelSyncManager(panelName).receiveWidgetUpdate(mapKey, id, buf);
+        PanelSyncManager psm = this.panelSyncManagerMap.get(panelName);
+        if (psm != null) {
+            psm.receiveWidgetUpdate(mapKey, id, buf);
+        } else if (!this.panelHistory.contains(panelName)) {
+            ModularUI.LOGGER.throwing(new IllegalStateException("A packet was send to panel '" + panelName + "' which was not opened yet!."));
+        }
+        // else the panel was open at some point
+        // we simply discard the packet silently and assume the packet was correctly send, but the panel closed earlier
     }
 
     public EntityPlayer getPlayer() {

src/main/java/com/cleanroommc/modularui/value/sync/PanelSyncHandler.java

@@ -69,18 +69,24 @@ private void openPanel(boolean syncToServer) {
         if (client) {
             ModularScreen screen = getSyncManager().getContainer().getScreen();
             if (!screen.isPanelOpen(this.openedPanel.getName())) {
+                openInModularSyncManager();
                 screen.getPanelManager().openPanel(this.openedPanel, this);
             } else {
                 // this was not supposed to happen
                 // make sure server side also closes the panel
                 closePanelInternal();
                 return;
             }
+        } else {
+            openInModularSyncManager();
         }
-        getSyncManager().getModularSyncManager().open(this.panelName, this.syncManager);
         this.open = true;
     }
 
+    private void openInModularSyncManager() {
+        getSyncManager().getModularSyncManager().open(this.panelName, this.syncManager);
+    }
+
     @Override
     public void closePanel() {
         if (getSyncManager().isClient()) {