From 952efb49f00fbfd8799a33b86c903c5cdd29ee2a Mon Sep 17 00:00:00 2001 From: Francisco Garcia Florez Date: Mon, 16 Mar 2026 11:33:56 +0100 Subject: [PATCH] fix: propagate container resources to version-probe job The buildVersionProbeJob function copies Image, ImagePullPolicy, SecurityContext, and Command from ContainerTemplate but omits Resources. This causes version-probe pods to lack CPU/memory requests, which triggers rejection by admission controllers that require resource requests (e.g. Gatekeeper). Add Resources field to the probe container spec, matching the pattern already used in ClickHouse and Keeper StatefulSet container builders. Co-Authored-By: Claude Opus 4.6 (1M context) --- internal/controller/clickhouse/controller_test.go | 1 + internal/controller/versionprobe.go | 1 + 2 files changed, 2 insertions(+) diff --git a/internal/controller/clickhouse/controller_test.go b/internal/controller/clickhouse/controller_test.go index d982830..57dd443 100644 --- a/internal/controller/clickhouse/controller_test.go +++ b/internal/controller/clickhouse/controller_test.go @@ -135,6 +135,7 @@ var _ = When("reconciling ClickHouseCluster", Ordered, func() { Expect(suite.Client.List(ctx, &jobs, listOpts)).To(Succeed()) Expect(jobs.Items).To(HaveLen(1)) Expect(jobs.Items[0].Labels[controllerutil.LabelRoleKey]).To(Equal(controllerutil.LabelVersionProbe)) + Expect(jobs.Items[0].Spec.Template.Spec.Containers[0].Resources).ToNot(BeZero()) testutil.AssertEvents(recorder.Events, map[string]int{ "ClusterNotReady": 1, diff --git a/internal/controller/versionprobe.go b/internal/controller/versionprobe.go index 3815850..8d48b17 100644 --- a/internal/controller/versionprobe.go +++ b/internal/controller/versionprobe.go @@ -205,6 +205,7 @@ func (r *ResourceReconcilerBase[Status, T, ReplicaID, S]) buildVersionProbeJob(c Image: cfg.ContainerTemplate.Image.String(), ImagePullPolicy: cfg.ContainerTemplate.ImagePullPolicy, SecurityContext: cfg.ContainerTemplate.SecurityContext, + Resources: cfg.ContainerTemplate.Resources, Command: []string{"sh", "-c", cfg.Binary + " --version > /dev/termination-log 2>&1"}, }, },