Correctly interpret the timestamps from kernel messages

Author: Jan Wilmans

application/CobaltFusion/Timer.cpp

@@ -40,10 +40,10 @@ void Timer::Reset()
 
 double Timer::Get()
 {
-    return GetTimeSince(GetTicks());
+    return GetTimeSinceOrigin(GetTicks());
 }
 
-double Timer::GetTimeSince(long long ticks)
+double Timer::GetTimeSinceOrigin(long long ticks)
 {
     // double-checked locking, prevents pessimizing the happy-path
     if (!m_init)

application/DebugViewpp/MainFrame.cpp

@@ -1399,6 +1399,11 @@ void CMainFrame::Pause()
         m_logSources.Remove(m_pGlobalReader);
         m_pGlobalReader = nullptr;
     }
+    if (m_pKernelReader != nullptr)
+    {
+        m_logSources.Remove(m_pKernelReader);
+        m_pKernelReader = nullptr;
+    }
     m_logSources.AddMessage("<paused>");
 }
 

application/DebugViewppLib/Debugview_kernel_client.cpp

@@ -6,7 +6,7 @@
 #include "DebugViewppLib/Debugview_kernel_client.h"
 
 constexpr const char* DRIVER_SERVICE_NAME = "debugviewdriver";
-constexpr const char* DRIVER_DISPLAY_NAME = "DebugViewPP Kernel Message Driver";
+constexpr const char* DRIVER_DISPLAY_NAME = "DbgView Kernel Message Driver";
 const std::string driverPath = "dbgv.sys";
 
 void InstallKernelMessagesDriver()

application/DebugViewppLib/KernelReader.cpp

@@ -64,7 +64,6 @@ KernelReader::KernelReader(Timer& timer, ILineBuffer& linebuffer) :
 {
     SetDescription(L"Kernel Message Reader");
     InstallKernelMessagesDriver();
-    AddMessage(0, "kernel", "Started capturing kernel messages");
     Signal();
     StartListening();
     StartThread();

application/DebugViewppLib/LogSource.cpp

@@ -92,5 +92,11 @@ void LogSource::AddInternal(const std::string& message) const
     m_linebuffer.Add(m_timer.Get(), Win32::GetSystemTimeAsFileTime(), 0, "[internal]", message, this);
 }
 
+double LogSource::GetTimeSinceOrigin(long long ticks) const
+{
+    return m_timer.GetTimeSinceOrigin(ticks);
+}
+
+
 } // namespace debugviewpp
 } // namespace fusion

application/include/CobaltFusion/Timer.h

@@ -19,7 +19,7 @@ class Timer
 
     void Reset();
     double Get();
-    double GetTimeSince(long long);
+    double GetTimeSinceOrigin(long long);
 
 private:
     double m_timerUnit;

application/include/DebugViewppLib/Debugview_kernel_client.h

@@ -38,10 +38,10 @@ void UninstallKernelMessagesDriver();
 #pragma pack(1)
 typedef struct
 {
-	DWORD dwIndex;
-	FILETIME liSystemTime;
-	LARGE_INTEGER liPerfCounter;
-	CHAR strData[0];
+    DWORD dwIndex;
+    FILETIME liSystemTime;
+    LARGE_INTEGER liPerfCounter;
+    CHAR strData[0];
 } LOG_ITEM, *PLOG_ITEM;
 #pragma pack()
 

application/include/DebugViewppLib/LogSource.h

@@ -64,6 +64,9 @@ class LogSource : public fusion::noncopyable
     // used by FileReader
     void Add(const std::string& message);
 
+    // get the relative time since the start of the session given the QWORD of the performance counter
+    double GetTimeSinceOrigin(long long ticks) const;
+
 private:
     bool m_autoNewLine = true;
     ILineBuffer& m_linebuffer;