fix setting defaults and some v12 issues

Author: Codas

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## 0.10.2
 
+- Fix setting defaults and v12 issues
+
+## 0.10.2
+
 - Fix application templates not being included in module package
 
 ## 0.10.1

module.json

@@ -1,7 +1,7 @@
 {
 	"id": "fvtt-perf-optim",
 	"title": "Prime Performance",
-	"version": "0.10.2",
+	"version": "0.10.3",
 	"description": "Provides a collection of unofficial performance optimizations and hacks for foundry vtt.",
 	"esmodules": ["dist/fvtt-perf-optim.js"],
 	"languages": [

src/apps/CustomRenderScaleMenu.ts

@@ -147,7 +147,8 @@ export class CustomRenderScaleConfig extends foundry.applications.api.Handlebars
 		const FormDataExtendedConstructor =
 			FOUNDRY_API.generation >= 13 ? foundry.applications.ux.FormDataExtended : FormDataExtended;
 
-		const formData = new FormDataExtendedConstructor(this.form);
+		const dataElement = FOUNDRY_API.generation >= 13 ? this.form : this.element;
+		const formData = new FormDataExtendedConstructor(dataElement);
 
 		this.#setting = foundry.utils.expandObject(formData.object) as typeof RENDER_SCALE_DEFAULTS;
 		configureEffectsResolution(this.#setting);

src/hacks/reduceLightingResolution.ts

@@ -1,5 +1,5 @@
-import type { RENDER_SCALE_DEFAULTS } from 'src/settings/constants.ts';
-import { SETTINGS } from 'src/settings/constants.ts';
+import { NAMESPACE } from 'src/constants.ts';
+import { RENDER_SCALE_DEFAULTS, SETTINGS } from 'src/settings/constants.ts';
 import { getSetting } from 'src/settings/settings.ts';
 import { FOUNDRY_API } from 'src/utils/foundryShim.ts';
 
@@ -24,7 +24,15 @@ async function enableReducedLightingResolution() {
 		if (!getSetting<boolean>(SETTINGS.ReduceLightingResolution)) {
 			return;
 		}
-		const customRenderScale = getSetting<typeof RENDER_SCALE_DEFAULTS>(SETTINGS.CustomRenderScale);
+		let customRenderScale = getSetting<typeof RENDER_SCALE_DEFAULTS>(SETTINGS.CustomRenderScale);
+
+		// TODO: remove in some future version, this is a workaround for settings being initialized as an array
+		// because I set the wrong default value in the settings file
+		if (Array.isArray(customRenderScale)) {
+			game.settings.set(NAMESPACE, SETTINGS.CustomRenderScale, RENDER_SCALE_DEFAULTS);
+			customRenderScale = RENDER_SCALE_DEFAULTS;
+		}
+
 		configureEffectsResolution(customRenderScale);
 	});
 }

src/settings/settings.ts

@@ -3,7 +3,7 @@ import { NAMESPACE } from 'src/constants.ts';
 import { toggleDisableAppBackgroundBlur } from 'src/hacks/disableAppBackgroundBlur.ts';
 import { configureEffectsResolution } from 'src/hacks/reduceLightingResolution.ts';
 import { CustomSpritesheetConfig } from '../apps/CustomSpritesheetConfig.ts';
-import { type RENDER_SCALE_DEFAULTS, SETTINGS } from './constants.ts';
+import { RENDER_SCALE_DEFAULTS, SETTINGS } from './constants.ts';
 
 export function getSetting<T = unknown>(settings: SETTINGS): T {
 	return game.settings.get<T>(NAMESPACE, settings);
@@ -104,7 +104,7 @@ Hooks.on('init', () => {
 		config: false,
 		scope: 'client',
 		type: Object,
-		default: [],
+		default: RENDER_SCALE_DEFAULTS,
 	});
 	game.settings.registerMenu(NAMESPACE, SETTINGS.CustomRenderScale, {
 		name: `${NAMESPACE}.settings.${SETTINGS.CustomRenderScale}.name`,