Refactoring on Credential Projects

Author: mckaragoz

samples/UAuthHub/CodeBeam.UltimateAuth.Sample.UAuthHub/Controllers/HubLoginController.cs

@@ -1,5 +1,6 @@
 using CodeBeam.UltimateAuth.Core.Abstractions;
 using CodeBeam.UltimateAuth.Core.Domain;
+using CodeBeam.UltimateAuth.Core.MultiTenancy;
 using CodeBeam.UltimateAuth.Core.Options;
 using CodeBeam.UltimateAuth.Server.Options;
 using CodeBeam.UltimateAuth.Server.Stores;
@@ -41,7 +42,7 @@ public async Task<IActionResult> BeginLogin(
             hubSessionId: hubSessionId,
             flowType: HubFlowType.Login,
             clientProfile: client_profile,
-            tenantId: null,
+            tenant: TenantKeys.System,
             returnUrl: return_url,
             payload: payload,
             expiresAt: _clock.UtcNow.Add(_options.Hub.FlowLifetime));

src/CodeBeam.UltimateAuth.Client/Abstractions/IBrowserStorage.cs

@@ -1,12 +1,11 @@
 using CodeBeam.UltimateAuth.Client.Contracts;
 
-namespace CodeBeam.UltimateAuth.Client.Utilities
+namespace CodeBeam.UltimateAuth.Client.Utilities;
+
+public interface IBrowserStorage
 {
-    public interface IBrowserStorage
-    {
-        ValueTask SetAsync(StorageScope scope, string key, string value);
-        ValueTask<string?> GetAsync(StorageScope scope, string key);
-        ValueTask RemoveAsync(StorageScope scope, string key);
-        ValueTask<bool> ExistsAsync(StorageScope scope, string key);
-    }
+    ValueTask SetAsync(StorageScope scope, string key, string value);
+    ValueTask<string?> GetAsync(StorageScope scope, string key);
+    ValueTask RemoveAsync(StorageScope scope, string key);
+    ValueTask<bool> ExistsAsync(StorageScope scope, string key);
 }

src/CodeBeam.UltimateAuth.Client/Abstractions/ISessionCoordinator.cs

@@ -1,18 +1,17 @@
-namespace CodeBeam.UltimateAuth.Client.Abstractions
+namespace CodeBeam.UltimateAuth.Client.Abstractions;
+
+public interface ISessionCoordinator : IAsyncDisposable
 {
-    public interface ISessionCoordinator : IAsyncDisposable
-    {
-        /// <summary>
-        /// Starts session coordination.
-        /// Should be idempotent.
-        /// </summary>
-        Task StartAsync(CancellationToken cancellationToken = default);
+    /// <summary>
+    /// Starts session coordination.
+    /// Should be idempotent.
+    /// </summary>
+    Task StartAsync(CancellationToken cancellationToken = default);
 
-        /// <summary>
-        /// Stops coordination (optional).
-        /// </summary>
-        Task StopAsync();
+    /// <summary>
+    /// Stops coordination (optional).
+    /// </summary>
+    Task StopAsync();
 
-        event Action? ReauthRequired;
-    }
+    event Action? ReauthRequired;
 }

src/CodeBeam.UltimateAuth.Client/Authentication/DefaultUAuthStateManager.cs

@@ -1,55 +1,54 @@
 using CodeBeam.UltimateAuth.Client.Runtime;
 using CodeBeam.UltimateAuth.Core.Abstractions;
 
-namespace CodeBeam.UltimateAuth.Client.Authentication
-{
-    internal sealed class DefaultUAuthStateManager : IUAuthStateManager
-    {
-        private readonly IUAuthClient _client;
-        private readonly IClock _clock;
-        private readonly IUAuthClientBootstrapper _bootstrapper;
-
-        public UAuthState State { get; } = UAuthState.Anonymous();
-
-        public DefaultUAuthStateManager(IUAuthClient client, IClock clock, IUAuthClientBootstrapper bootstrapper)
-        {
-            _client = client;
-            _clock = clock;
-            _bootstrapper = bootstrapper;
-        }
+namespace CodeBeam.UltimateAuth.Client.Authentication;
 
-        public async Task EnsureAsync(CancellationToken ct = default)
-        {   
-            if (State.IsAuthenticated && !State.IsStale)
-                return;
+internal sealed class DefaultUAuthStateManager : IUAuthStateManager
+{
+    private readonly IUAuthClient _client;
+    private readonly IClock _clock;
+    private readonly IUAuthClientBootstrapper _bootstrapper;
 
-            await _bootstrapper.EnsureStartedAsync();
-            var result = await _client.Flows.ValidateAsync();
+    public UAuthState State { get; } = UAuthState.Anonymous();
 
-            if (!result.IsValid)
-            {
-                State.Clear();
-                return;
-            }
+    public DefaultUAuthStateManager(IUAuthClient client, IClock clock, IUAuthClientBootstrapper bootstrapper)
+    {
+        _client = client;
+        _clock = clock;
+        _bootstrapper = bootstrapper;
+    }
 
-            State.ApplySnapshot(result.Snapshot, _clock.UtcNow);
-        }
+    public async Task EnsureAsync(CancellationToken ct = default)
+    {   
+        if (State.IsAuthenticated && !State.IsStale)
+            return;
 
-        public Task OnLoginAsync()
-        {
-            State.MarkStale();
-            return Task.CompletedTask;
-        }
+        await _bootstrapper.EnsureStartedAsync();
+        var result = await _client.Flows.ValidateAsync();
 
-        public Task OnLogoutAsync()
+        if (!result.IsValid)
         {
             State.Clear();
-            return Task.CompletedTask;
+            return;
         }
 
-        public void MarkStale()
-        {
-            State.MarkStale();
-        }
+        State.ApplySnapshot(result.Snapshot, _clock.UtcNow);
+    }
+
+    public Task OnLoginAsync()
+    {
+        State.MarkStale();
+        return Task.CompletedTask;
+    }
+
+    public Task OnLogoutAsync()
+    {
+        State.Clear();
+        return Task.CompletedTask;
+    }
+
+    public void MarkStale()
+    {
+        State.MarkStale();
     }
 }

src/CodeBeam.UltimateAuth.Client/Authentication/IUAuthStateManager.cs

@@ -1,36 +1,35 @@
-namespace CodeBeam.UltimateAuth.Client.Authentication
+namespace CodeBeam.UltimateAuth.Client.Authentication;
+
+/// <summary>
+/// Orchestrates the lifecycle of UAuthState.
+/// This is the single authority responsible for keeping
+/// client-side authentication state in sync with the server.
+/// </summary>
+public interface IUAuthStateManager
 {
     /// <summary>
-    /// Orchestrates the lifecycle of UAuthState.
-    /// This is the single authority responsible for keeping
-    /// client-side authentication state in sync with the server.
+    /// Current in-memory authentication state.
     /// </summary>
-    public interface IUAuthStateManager
-    {
-        /// <summary>
-        /// Current in-memory authentication state.
-        /// </summary>
-        UAuthState State { get; }
+    UAuthState State { get; }
 
-        /// <summary>
-        /// Ensures the authentication state is valid.
-        /// May call server validate/refresh if needed.
-        /// </summary>
-        Task EnsureAsync(CancellationToken ct = default);
+    /// <summary>
+    /// Ensures the authentication state is valid.
+    /// May call server validate/refresh if needed.
+    /// </summary>
+    Task EnsureAsync(CancellationToken ct = default);
 
-        /// <summary>
-        /// Called after a successful login.
-        /// </summary>
-        Task OnLoginAsync();
+    /// <summary>
+    /// Called after a successful login.
+    /// </summary>
+    Task OnLoginAsync();
 
-        /// <summary>
-        /// Called after logout.
-        /// </summary>
-        Task OnLogoutAsync();
+    /// <summary>
+    /// Called after logout.
+    /// </summary>
+    Task OnLogoutAsync();
 
-        /// <summary>
-        /// Forces state to be cleared and re-validation required.
-        /// </summary>
-        void MarkStale();
-    }
+    /// <summary>
+    /// Forces state to be cleared and re-validation required.
+    /// </summary>
+    void MarkStale();
 }

src/CodeBeam.UltimateAuth.Client/Authentication/UAuthAuthenticatonStateProvider.cs

@@ -1,24 +1,21 @@
-using CodeBeam.UltimateAuth.Client.Abstractions;
-using Microsoft.AspNetCore.Components.Authorization;
-using System.Security.Principal;
+using Microsoft.AspNetCore.Components.Authorization;
 
-namespace CodeBeam.UltimateAuth.Client.Authentication
-{
-    internal sealed class UAuthAuthenticationStateProvider : AuthenticationStateProvider
-    {
-        private readonly IUAuthStateManager _stateManager;
+namespace CodeBeam.UltimateAuth.Client.Authentication;
 
-        public UAuthAuthenticationStateProvider(IUAuthStateManager stateManager)
-        {
-            _stateManager = stateManager;
-            _stateManager.State.Changed += _ => NotifyAuthenticationStateChanged(GetAuthenticationStateAsync());
-        }
+internal sealed class UAuthAuthenticationStateProvider : AuthenticationStateProvider
+{
+    private readonly IUAuthStateManager _stateManager;
 
-        public override Task<AuthenticationState> GetAuthenticationStateAsync()
-        {
-            var principal = _stateManager.State.ToClaimsPrincipal();
-            return Task.FromResult(new AuthenticationState(principal));
-        }
+    public UAuthAuthenticationStateProvider(IUAuthStateManager stateManager)
+    {
+        _stateManager = stateManager;
+        _stateManager.State.Changed += _ => NotifyAuthenticationStateChanged(GetAuthenticationStateAsync());
+    }
 
+    public override Task<AuthenticationState> GetAuthenticationStateAsync()
+    {
+        var principal = _stateManager.State.ToClaimsPrincipal();
+        return Task.FromResult(new AuthenticationState(principal));
     }
+
 }

src/CodeBeam.UltimateAuth.Client/Authentication/UAuthCascadingStateProvider.cs

@@ -1,26 +1,25 @@
 using Microsoft.AspNetCore.Components;
 
-namespace CodeBeam.UltimateAuth.Client.Authentication
+namespace CodeBeam.UltimateAuth.Client.Authentication;
+
+internal sealed class UAuthCascadingStateProvider : CascadingValueSource<UAuthState>, IDisposable
 {
-    internal sealed class UAuthCascadingStateProvider : CascadingValueSource<UAuthState>, IDisposable
-    {
-        private readonly IUAuthStateManager _stateManager;
+    private readonly IUAuthStateManager _stateManager;
 
-        public UAuthCascadingStateProvider(IUAuthStateManager stateManager)
-            : base(() => stateManager.State, isFixed: false)
-        {
-            _stateManager = stateManager;
-            _stateManager.State.Changed += OnStateChanged;
-        }
+    public UAuthCascadingStateProvider(IUAuthStateManager stateManager)
+        : base(() => stateManager.State, isFixed: false)
+    {
+        _stateManager = stateManager;
+        _stateManager.State.Changed += OnStateChanged;
+    }
 
-        private void OnStateChanged(UAuthStateChangeReason _)
-        {
-            NotifyChangedAsync();
-        }
+    private void OnStateChanged(UAuthStateChangeReason _)
+    {
+        NotifyChangedAsync();
+    }
 
-        public void Dispose()
-        {
-            _stateManager.State.Changed -= OnStateChanged;
-        }
+    public void Dispose()
+    {
+        _stateManager.State.Changed -= OnStateChanged;
     }
 }