London | 26-ITP-Jan | Shuheda Begum | Sprint 2 | FORM-Control by codebyshay · Pull Request #1021 · CodeYourFuture/Module-Onboarding

codebyshay · 2026-01-23T14:17:53Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have created a form that collects customer t-shirt orders. I have added validation on both names and emails.

Questions

No Questions

…dded validation on both names and emails.

netlify · 2026-01-23T14:17:58Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`ec07304`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/697d02267903e00008287b30
😎 Deploy Preview	https://deploy-preview-1021--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 71 (🔴 down 15 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

I added required> to name, email, select colour and select size.

jenny-alexander

Hi @codebyshay - good work. I left a few comments within the code.

Also, can you check the Lighthouse accessibility score for your form page? I see it as 89 and the exercise requirements say it should be 100.

jenny-alexander · 2026-01-28T22:56:46Z

Form-Controls/index.html

+    <button type="submit">Submit</button>
+  </form>
+
+  <script>


Can you review the exercise instructions? I believe there shouldn't be any javascript in the file.

jenny-alexander · 2026-01-28T23:09:13Z

Form-Controls/index.html

+  </script>
+
+  <footer>
+    <h2>By Shuheda Begum</h2>


The <h2> tag in the footer suggests a major section heading. Footer typically has smaller headings or <p> tags.

Footer changed from <h2> to <p. Block and padding added around the <label tag.

codebyshay · 2026-01-29T00:00:21Z

Hi, I've amended footer and the <label. This was the cause behind the 89% score on lighthouse. Lighthouse accessibility score is now 100%. Will change the code to eliminate JavaScript tomorrow.

jenny-alexander · 2026-01-29T05:34:48Z

Form-Controls/index.html

+        <input type="radio" name="size" value="XS" required> XS
+      </label>
+
+      <label style="display:block; padding:12px 0;">


I missed this in my prior review -> Ensure that you don't add CSS to the file, as stated in the instructions.

All done. JavaScript and CSS removed. Lighthouse score 100%. Thank you.

jenny-alexander · 2026-01-30T04:41:38Z

@codebyshay - Your form works well. Thanks for making the suggested corrections.
When I use W3 validator to review your deployed application, there are multiple errors. Can you please review?
https://validator.w3.org/

codebyshay · 2026-01-30T06:53:28Z

Was that part of the requirements? I don't remember seeing anything about validation via W3?

jenny-alexander · 2026-01-30T13:26:00Z

Hi @codebyshay Even though running W3 validator checks isn't explicitly stated in the CYF requirements, writing valid HTML is a baseline expectation for any web development work.
Invalid markup can cause unexpected browser behaviour, accessibility problems, and maintenance problems down the line.

It's a good habit to run your markup through W3 validator at this stage of your development journey.

codebyshay · 2026-01-30T13:32:40Z

I appreciate it's good practice, but I believe I have fulfilled the criteria for this part of the course.

cjyuan · 2026-01-30T16:07:55Z

@codebyshay Your form implementation looks good.

While it's not explicitly stated in the spec, things like "valid HTML" are usually assumed rather than written into requirements in a real job.

CYF asks mentors to hold trainees to a high standard in order to better prepare them for the real world.
That’s why @jenny-alexander and I are encouraging trainees to develop the habit of validating their code.
Our goal isn’t to add extra rules, but to help trainees consistently deliver work that meets professional standards and can stand up to review in a real job.

It should be an easy fix. Can you try?

codebyshay · 2026-01-30T19:09:38Z

Thank you @cjyuan I am a complete novice when it comes to coding, so I am not familiar with expectations or common practices amongst coders. I am however, trying hard to learn. I appreciate the feedback provided by yourself and @jenny-alexander. I have attempted it to make the code valid, hopefully all is in order now.

I have created a form that collects customer t-shirt orders. I have a…

b1f2afc

…dded validation on both names and emails.

codebyshay added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

Required elements

2a721e7

I added required> to name, email, select colour and select size.

codebyshay mentioned this pull request Jan 24, 2026

26-ITP-Jan | Onboarding | Shuheda Begum codebyshay/My-Coursework-Planner#19

Open

jenny-alexander self-requested a review January 28, 2026 22:23

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 28, 2026

jenny-alexander reviewed Jan 28, 2026

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 28, 2026

Footer and label changed

1ac037c

Footer changed from <h2> to <p. Block and padding added around the <label tag.

jenny-alexander reviewed Jan 29, 2026

View reviewed changes

codebyshay added 2 commits January 29, 2026 22:05

JavaScript Removed

777b38f

CSS removed

2582253

codebyshay added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 29, 2026

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026

codebyshay added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026

Validated HTML Code

ec07304

Uh oh!

Conversation

codebyshay commented Jan 23, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

netlify bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

codebyshay commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jenny-alexander Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

codebyshay Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codebyshay commented Jan 30, 2026

Uh oh!

jenny-alexander commented Jan 30, 2026

Uh oh!

codebyshay commented Jan 30, 2026

Uh oh!

cjyuan commented Jan 30, 2026

Uh oh!

codebyshay commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jan 23, 2026 •

edited

Loading

codebyshay commented Jan 29, 2026 •

edited

Loading

jenny-alexander commented Jan 30, 2026 •

edited

Loading