From 45fc25d7ec31a55d0881b875434e4fd1f03097ce Mon Sep 17 00:00:00 2001
From: Mona-Eltantawy <karamrafat@gmail.com>
Date: Mon, 26 Jan 2026 22:07:43 +0000
Subject: [PATCH 1/4] Added: - Inputs for customer name and email.  -Associated
 lables.  - Rquried a valid name and email.

---
 Form-Controls/index.html | 49 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 45 insertions(+), 4 deletions(-)
diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 65a866cdb..868eb0c3d 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -7,16 +7,57 @@
     <meta name="description" content="" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
   </head>
+  
   <body>
     <header>
       <h1>Product Pick</h1>
     </header>
     <main>
       <form>
-        <!-- write your html here-->
-        <!-- 
-          try writing out the requirements first as comments
-        this will also help you fill in your PR message later-->
+        
+      
+<fieldset>
+  <legend>Customer Information</legend>
+   <p>please insert your information below:</p>
+
+ <div>
+ <label for="txt">user name</label>
+<input id="txt" type="text" placeholder="user-name" maxlength="20" minlength="5" required>
+</div>
+
+<div>
+<label for="password">password</label>
+<input id="password" type="password" placeholder="password" minlength="8" required>
+</div>
+
+<div>
+<label for="email">email</label>
+<input id="email" type="email" placeholder="Ex:adbsefg@ghh.com" required>
+</div>
+
+<div>
+<label for="tel">Phone number</label>
+<input id="tel" type="tel" placeholder="+44-123-456-789" required>
+        </div>
+        
+        </fieldset>
+
+        <fieldset>
+          <legend>Product Information</legend>
+<dive>
+  <p>please select the product details</p>
+
+</dive>
+<dive>
+  <label for="submit">submit</label>
+  <input id="submit" type="submit" value="send">
+</dive>
+</fieldset>
+        <!-- 1. What is the customer's name? I must collect this data, and validate it. But what is a valid name? I must decide something.
+2. What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern.
+3. What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours?
+4. What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL -->
+
       </form>
     </main>
     <footer>

From 96549ee131b0e34dfe827647409770329ea2ea7d Mon Sep 17 00:00:00 2001
From: Mona-Eltantawy <karamrafat@gmail.com>
Date: Wed, 28 Jan 2026 21:25:37 +0000
Subject: [PATCH 2/4] Added new fieldset for product details, included: - size
 -colour -quantity

---
 Form-Controls/index.html | 159 +++++++++++++++++++++++----------------
 1 file changed, 94 insertions(+), 65 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 868eb0c3d..a260f1596 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -1,68 +1,97 @@
 <!DOCTYPE html>
 <html lang="en">
-  <head>
-    <meta charset="utf-8" />
-    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
-    <title>My form exercise</title>
-    <meta name="description" content="" />
-    <meta name="viewport" content="width=device-width, initial-scale=1" />
-  </head>
-  
-  <body>
-    <header>
-      <h1>Product Pick</h1>
-    </header>
-    <main>
-      <form>
-        
-      
-<fieldset>
-  <legend>Customer Information</legend>
-   <p>please insert your information below:</p>
-
- <div>
- <label for="txt">user name</label>
-<input id="txt" type="text" placeholder="user-name" maxlength="20" minlength="5" required>
-</div>
-
-<div>
-<label for="password">password</label>
-<input id="password" type="password" placeholder="password" minlength="8" required>
-</div>
-
-<div>
-<label for="email">email</label>
-<input id="email" type="email" placeholder="Ex:adbsefg@ghh.com" required>
-</div>
-
-<div>
-<label for="tel">Phone number</label>
-<input id="tel" type="tel" placeholder="+44-123-456-789" required>
+
+<head>
+  <meta charset="utf-8" />
+  <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+  <title>My form exercise</title>
+  <meta name="description" content="" />
+  <meta name="viewport" content="width=device-width, initial-scale=1" />
+</head>
+
+<body>
+  <header>
+    <h1>Product Pick</h1>
+  </header>
+
+  <main>
+
+    <form>
+      <fieldset>
+        <legend>Customer Information</legend>
+        <br>
+
+        <div>
+          <label for="txt">User name</label>
+          <input id="txt" type="text" placeholder="please insert a valid name" minlength="2" required>
+        </div>
+        <br>
+        <div>
+          <label for="password">Password</label>
+          <input id="password" type="password"
+            placeholder="please insert a valid password contains at least 8 characters" minlength="8" required>
+        </div>
+
+        <div>
+          <label for="email">Email</label>
+          <input id="email" type="email" placeholder="please insert a valid email/Ex:adbsefg@ghh.com" required>
+        </div>
+
+      </fieldset>
+
+      <br>
+      <fieldset>
+        <legend>Product Information</legend>
+
+        <div>
+          <label for="colour">Select colour</label>
+          <input list="colour"  required>
+          <datalist id="colour">
+
+            <option value="red">
+            <option value="blue">
+            <option value="green">
+
+          </datalist>
+
         </div>
-        
-        </fieldset>
-
-        <fieldset>
-          <legend>Product Information</legend>
-<dive>
-  <p>please select the product details</p>
-
-</dive>
-<dive>
-  <label for="submit">submit</label>
-  <input id="submit" type="submit" value="send">
-</dive>
-</fieldset>
-        <!-- 1. What is the customer's name? I must collect this data, and validate it. But what is a valid name? I must decide something.
-2. What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern.
-3. What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours?
-4. What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL -->
-
-      </form>
-    </main>
-    <footer>
-      <!-- change to your name-->
-      <h2>By HOMEWORK SOLUTION</h2>
-    </footer>
-  </body>
-</html>
+
+        <div>
+
+          <label for="size">Select size</label>
+          <select name="size" id="size">
+
+            <option value="XS">xs</option>
+            <option value="S">s</option>
+            <option value="M">M </option>
+            <option value="L">L</option>
+            <option value="XL">XL</option>
+            <option value="XXL">XXL</option>
+          </select>
+          </dive>
+          <div>
+            <label for="quantity">Select quantity</label>
+            <input type="number" Id="quantity" min="1" max="100" required>
+          </div>
+
+          <br>
+          <hr>
+          <div>
+            <label for="submit">submit</label>
+            <input id="submit" type="submit" value="send">
+          </div>
+      </fieldset>
+
+
+    </form>
+  </main>
+  <footer>
+    <h3>
+      By Mona_Eltantawy
+
+    </h3>
+
+  </footer>
+</body>
+
+</html>
\ No newline at end of file

From 1b069eb0e47391fc03ad4f81cf3260f089e535f8 Mon Sep 17 00:00:00 2001
From: Mona-Eltantawy <karamrafat@gmail.com>
Date: Wed, 28 Jan 2026 21:31:24 +0000
Subject: [PATCH 3/4] Edited typo symatics.

---
 Form-Controls/index.html | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index a260f1596..b5fea30ce 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -28,8 +28,7 @@ <h1>Product Pick</h1>
         <br>
         <div>
           <label for="password">Password</label>
-          <input id="password" type="password"
-            placeholder="please insert a valid password contains at least 8 characters" minlength="8" required>
+          <input id="password" type="password" placeholder="At least 8 characters" minlength="8" required>
         </div>
 
         <div>
@@ -45,7 +44,7 @@ <h1>Product Pick</h1>
 
         <div>
           <label for="colour">Select colour</label>
-          <input list="colour"  required>
+          <input list="colour" id="colour" name="colour" required>
           <datalist id="colour">
 
             <option value="red">
@@ -68,21 +67,19 @@ <h1>Product Pick</h1>
             <option value="XL">XL</option>
             <option value="XXL">XXL</option>
           </select>
-          </dive>
-          <div>
-            <label for="quantity">Select quantity</label>
-            <input type="number" Id="quantity" min="1" max="100" required>
-          </div>
-
-          <br>
-          <hr>
-          <div>
-            <label for="submit">submit</label>
-            <input id="submit" type="submit" value="send">
-          </div>
-      </fieldset>
+        </div>
+        <div>
+          <label for="quantity">Select quantity</label>
+          <input type="number" id="quantity" min="1" max="100" required>
+        </div>
 
+        <br>
+        <hr>
+        <div>
 
+          <input id="submit" type="submit" value="send">
+        </div>
+      </fieldset>
     </form>
   </main>
   <footer>

From 50b3131b3a6ac728120473bad549462e137dedf3 Mon Sep 17 00:00:00 2001
From: Mona-Eltantawy <karamrafat@gmail.com>
Date: Wed, 28 Jan 2026 22:03:34 +0000
Subject: [PATCH 4/4] Added more spaces using html<br> & <hr> attributes

---
 Form-Controls/index.html | 76 ++++++++++++++++++----------------------
 1 file changed, 34 insertions(+), 42 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index b5fea30ce..1980b1c6f 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -15,79 +15,71 @@ <h1>Product Pick</h1>
   </header>
 
   <main>
-
     <form>
       <fieldset>
         <legend>Customer Information</legend>
-        <br>
 
         <div>
-          <label for="txt">User name</label>
-          <input id="txt" type="text" placeholder="please insert a valid name" minlength="2" required>
-        </div>
-        <br>
+          <label for="username">User name</label><br>
+          <input id="username" name="username" type="text" placeholder="Your name" minlength="2" autocomplete="username"
+            required size="30">
+        </div><br>
+
         <div>
-          <label for="password">Password</label>
-          <input id="password" type="password" placeholder="At least 8 characters" minlength="8" required>
-        </div>
+          <label for="password">Password</label><br>
+          <input id="password" name="password" type="password" placeholder="At least 8 characters" minlength="8"
+            autocomplete="current-password" required size="30">
+        </div><br>
 
         <div>
-          <label for="email">Email</label>
-          <input id="email" type="email" placeholder="please insert a valid email/Ex:adbsefg@ghh.com" required>
+          <label for="email">Email</label><br>
+          <input id="email" name="email" type="email" placeholder="example@email.com" autocomplete="email" required
+            size="30">
         </div>
-
       </fieldset>
 
-      <br>
       <fieldset>
         <legend>Product Information</legend>
 
         <div>
-          <label for="colour">Select colour</label>
-          <input list="colour" id="colour" name="colour" required>
-          <datalist id="colour">
-
-            <option value="red">
-            <option value="blue">
-            <option value="green">
-
-          </datalist>
-
-        </div>
+          <label for="colour">Select colour</label><br>
+          <select id="colour" name="colour" autocomplete="off" required>
+            <option>--Choose a colour--</option>
+            <option value="red">red</option>
+            <option value="blue">blue</option>
+            <option value="grey">grey</option>
+          </select>
+        </div><br>
 
         <div>
-
-          <label for="size">Select size</label>
-          <select name="size" id="size">
-
-            <option value="XS">xs</option>
-            <option value="S">s</option>
-            <option value="M">M </option>
+          <label for="size">Select size</label><br>
+          <select name="size" id="size" autocomplete="off" required>
+            <option value="">--Choose a size--</option>
+            <option value="XS">XS</option>
+            <option value="S">S</option>
+            <option value="M">M</option>
             <option value="L">L</option>
             <option value="XL">XL</option>
             <option value="XXL">XXL</option>
           </select>
-        </div>
+        </div><br>
+
         <div>
-          <label for="quantity">Select quantity</label>
-          <input type="number" id="quantity" min="1" max="100" required>
+          <label for="quantity">Select quantity</label><br>
+          <input type="number" id="quantity" name="quantity" min="1" max="100" autocomplete="off" required>
         </div>
 
-        <br>
         <hr>
-        <div>
 
-          <input id="submit" type="submit" value="send">
+        <div>
+          <input type="submit" value="Send">
         </div>
       </fieldset>
     </form>
   </main>
-  <footer>
-    <h3>
-      By Mona_Eltantawy
-
-    </h3>
 
+  <footer>
+    <h2>By Mona_Eltantawy</h2>
   </footer>
 </body>
 
