Completed 2-is-proper-fraction.test.js and modified function in 2-is-proper-fraction.js

Author: A-Moiz

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -24,12 +24,13 @@ function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
   }
-  if (angle < 90) {
+  if (angle > 0 && angle < 90) {
     return "Acute angle";
   }
   if (angle > 90 && angle < 180) {
     return "Obtuse angle";
   }
+  return "Invalid angle";
   // Run the tests, work out what Case 2 is testing, and implement the required code here.
   // Then keep going for the other cases, one at a time.
 }

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,7 +11,9 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (denominator === 0) {
+    return false;
+  } else if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
   } else {
     return false;

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,19 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+test(`should return true for proper fraction with positive numerator and denominator`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+});
+
+test(`should return false for improper fraction with positive numerator and denominator`, () => {
+  expect(isProperFraction(3, 2)).toEqual(false);
+});
+
+test(`should return true for numerator zero and positive denominator`, () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+});
+
+test(`should return false for denominator zero`, () => {
+  expect(isProperFraction(5, 0)).toEqual(false);
+});