added a test for only 16 digits with spaces or operators, updated variable name, and refactored previous password as a function input

Author: TzeMingHo

Sprint-3/3-stretch/creditCard-validator.js

@@ -1,6 +1,7 @@
 function creditCardValidator(cardNumber) {
   // declare the length of valid card number
   const VALID_LENGTH = 16;
+  const minimumSum = 16;
 
   // Remove all - and spaces from the input
   const sanitized = cardNumber.replace(/[-\s]/g, "");
@@ -30,7 +31,7 @@ function creditCardValidator(cardNumber) {
   const sum = sanitized
     .split("")
     .reduce((total, digit) => total + Number(digit), 0);
-  if (sum <= VALID_LENGTH) {
+  if (sum <= minimumSum) {
     return false;
   }
 

Sprint-3/3-stretch/creditCard-validator.test.js

@@ -38,4 +38,11 @@ describe("creditCardValidator", () => {
     expect(creditCardValidator("12345678901234567")).toBe(false);
     expect(creditCardValidator("1234-5678-9012-34567")).toBe(false);
   });
+
+  // test for only 16 digits without spaces or dashes
+  test("should return true for a card number with 16 digits without spaces or dashes", () => {
+    expect(creditCardValidator("1234567890123456")).toBe(true);
+    expect(creditCardValidator("0000000000000000")).toBe(false);
+    expect(creditCardValidator("1111111111111111")).toBe(false);
+  });
 });

Sprint-3/3-stretch/password-validator.js

@@ -1,4 +1,12 @@
-function passwordValidator(password) {
+const previousPasswords = [
+  "123Ab!",
+  "abcD1#",
+  "Password1!",
+  "Qwerty1*",
+  "Zxcvbnm2$",
+];
+
+function isValidPassword(password, previousPasswords) {
   const lengthCondition = password.length >= 5;
   console.log(`length condition: ${lengthCondition}`);
 
@@ -14,13 +22,6 @@ function passwordValidator(password) {
   const symbolCondition = /[!#$%.*&]/.test(password);
   console.log(`symbol condition: ${symbolCondition}`);
 
-  const previousPasswords = [
-    "123Ab!",
-    "abcD1#",
-    "Password1!",
-    "Qwerty1*",
-    "Zxcvbnm2$",
-  ];
   const notInPreviousPasswords = !previousPasswords.includes(password);
   console.log(`previous password condition: ${notInPreviousPasswords}`);
 
@@ -34,4 +35,4 @@ function passwordValidator(password) {
   );
 }
 
-module.exports = passwordValidator;
+module.exports = { isValidPassword, previousPasswords };

Sprint-3/3-stretch/password-validator.test.js

@@ -14,58 +14,58 @@ To be valid, a password must:
 
 You must breakdown this problem in order to solve it. Find one test case first and get that working
 */
-const isValidPassword = require("./password-validator");
+const { isValidPassword, previousPasswords } = require("./password-validator");
 
 describe("passwordValidator", () => {
   const validPassword = "123Ab*";
 
   test("returns true for passwords with at least 5 characters", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   test("return true for passwords with at least one uppercase letter", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   test("return true for passwords with at least one lowercase letter", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   test("return true for passwords with at least one number", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   test("return true for passwords with at least one non-alphanumeric symbol", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   test("return true for passwords that are not in the previous passwords array", () => {
-    expect(isValidPassword(validPassword)).toBe(true);
+    expect(isValidPassword(validPassword, previousPasswords)).toBe(true);
   });
 
   // tests for false cases
 
   test("returns false for passwords with less than 5 characters", () => {
-    expect(isValidPassword("1234")).toBe(false);
+    expect(isValidPassword("1234", previousPasswords)).toBe(false);
   });
 
   test("returns false for passwords without an uppercase letter", () => {
-    expect(isValidPassword("123ab*")).toBe(false);
+    expect(isValidPassword("123ab*", previousPasswords)).toBe(false);
   });
 
   test("returns false for passwords without a lowercase letter", () => {
-    expect(isValidPassword("123AB*")).toBe(false);
+    expect(isValidPassword("123AB*", previousPasswords)).toBe(false);
   });
 
   test("returns false for passwords without a number", () => {
-    expect(isValidPassword("abAB*")).toBe(false);
+    expect(isValidPassword("abAB*", previousPasswords)).toBe(false);
   });
 
   test("returns false for passwords without a non-alphanumeric symbol", () => {
-    expect(isValidPassword("123Abc")).toBe(false);
+    expect(isValidPassword("123Abc", previousPasswords)).toBe(false);
   });
 
   test("returns false for passwords that are in the previous passwords array", () => {
-    expect(isValidPassword("123Ab!")).toBe(false);
+    expect(isValidPassword("123Ab!", previousPasswords)).toBe(false);
   });
 });