Glasgow| 25-ITP-Sep | Abraham-Habte| Sprint 1 | Coursework/Sprint 1#736
Glasgow| 25-ITP-Sep | Abraham-Habte| Sprint 1 | Coursework/Sprint 1#736Abrsh100 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Abrsh100
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
…r modifiy the code taccording to the error
Abrsh100
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
added
the
Review in progress
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Remember to update the default PR text when submitting on github. It's helpful to include a brief description of what you've done
Sprint-1/2-mandatory-errors/4.js
Outdated
| const 24hourClockTime = "08:53"; | ||
| // the 12 and 24 are changing position | ||
| const 24HourClockTime = "20:53"; | ||
| const 12hourClockTime = "08:53"; No newline at end of file |
There was a problem hiding this comment.
Have you tried running this code in a console or in node? Do you see what the error might be?
| @@ -1,4 +1,4 @@ | |||
| const penceString = "399p"; | |||
| onst penceString = "399p"; | |||
There was a problem hiding this comment.
Do you see what you have changed on this line? Will the code still work?
LonMcGregor
added
Reviewed
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Abrsh100
added
Needs Review
|
Great work on this sprint, it's complete now |
LonMcGregor
added
Complete
|
Thank you LonMcGregor for your time and support |
3 participants
Uh oh!
There was an error while loading. Please reload this page.