Glasgow | 25-ITP-Sep | Fares Bakhet | Sprint 3 | coursework/sprint-3-practice-tdd by Fares-Bakhet · Pull Request #757 · CodeYourFuture/Module-Structuring-and-Testing-Data

Fares-Bakhet · 2025-10-12T21:30:24Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Build up functions, add tests.
Run the suitable tests.

Questions

No questions.

cjyuan · 2025-10-25T09:17:59Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  num = num.toString();
+  if (
+    num.slice(-2) === "11" ||
+    num.slice(-2) === "12" ||
+    num.slice(-2) === "13"
+  ) {
+    return num + "th";
+  } else if (num.slice(-1) === "1") {
+    return num + "st";
+    return num + "st";
+  } else if (num.slice(-1) === "2") {
+    return num + "nd";
+  } else if (num.slice(-1) === "3") {
+    return num + "rd";
+  } else {
+    return num + "th";
+  }
 }


There is an unreachable statement (dead code).

Note: because of the return statements, using else is optional.

@cjyuan, Found it 😅😅😅

cjyuan · 2025-10-25T09:19:47Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

@cjyuan, Done 🫡

cjyuan · 2025-10-25T09:21:54Z

Sprint-3/2-practice-tdd/repeat.js

+  const str = arguments[0];
+  const count = arguments[1];


Why not just declare them as parameters?

@cjyuan , Okay 👌

cjyuan · 2025-10-25T13:38:29Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

-
-test("should return '101st' for 101", () => {
-  expect(getOrdinalNumber(101)).toEqual("101st");
+test("should return 'th' for the rest numbers", () => {


"the rest [of the] numbers" is not very informative by itself; the developer would need to read all the test descriptions to find out what "the rest ..." mean. Can you make this test description more informative?

cjyuan · 2025-10-25T13:38:59Z

Sprint-3/2-practice-tdd/repeat.js

+  //const str = arguments[0];
+  //const count = arguments[1];


Why keep the unused code?

cjyuan · 2025-10-25T13:40:53Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

  }
+  return num + "th";


Since you have decided to remove the optional else, why only remove the last else?

@cjyuan, Okay

cjyuan

Changes look good! Well done.

Fares-Bakhet added 6 commits October 12, 2025 21:10

Biuld a countChar Code

6ab27fc

Pass the count code test

9c2b470

Build getOrdinalNumber code

48dba8f

Pass getOrdinalNumber tests

76de1ca

Build a function repeat code

7323aba

Pass the function repeat tests

80cde9a

Fares-Bakhet added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Oct 12, 2025

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025

cjyuan reviewed Oct 25, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 25, 2025

Fares-Bakhet added 3 commits October 25, 2025 11:04

Deleting the unreachable code and else form the last return

bea3492

Grouping the tests

44f3ca1

Editing the code

c2a674b

Fares-Bakhet added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 25, 2025

cjyuan reviewed Oct 25, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025

Fares-Bakhet added 3 commits October 25, 2025 14:51

Editing last test

7d3028f

Delete unsued code

1590eec

Removing all the unnecessary

2478386

Fares-Bakhet added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 25, 2025

cjyuan reviewed Oct 25, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025

Fares-Bakhet mentioned this pull request Oct 28, 2025

25-SEP-ITP| Structuring and testing data | Fares Bakhet Fares-Bakhet/My-Coursework-Planner#57

Open

illicitonion closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Glasgow | 25-ITP-Sep | Fares Bakhet | Sprint 3 | coursework/sprint-3-practice-tdd#757

Glasgow | 25-ITP-Sep | Fares Bakhet | Sprint 3 | coursework/sprint-3-practice-tdd#757
Fares-Bakhet wants to merge 12 commits intoCodeYourFuture:mainfrom
Fares-Bakhet:coursework/sprint-3-practice-tdd

Fares-Bakhet commented Oct 12, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

Fares-Bakhet Oct 25, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

Fares-Bakhet Oct 25, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

Fares-Bakhet Oct 25, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

cjyuan Oct 25, 2025

Uh oh!

Fares-Bakhet Oct 25, 2025

Uh oh!

cjyuan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Fares-Bakhet commented Oct 12, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants