Merge pull request #2 from CoderGamester/develop

Release 0.1.2

Author: CoderGamester

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.1.2] - 2020-07-29
+
+**Fixed**:
+- Fixed notification channel for Android
+
 ## [0.1.1] - 2020-07-29
 
 **Fixed**:

Runtime/Android/AndroidNotificationsPlatform.cs

@@ -1,5 +1,6 @@
 #if UNITY_ANDROID
 using System;
+using System.Linq;
 using Unity.Notifications.Android;
 
 // ReSharper disable once CheckNamespace
@@ -29,6 +30,31 @@ public AndroidNotificationsPlatform()
             AndroidNotificationCenter.OnNotificationReceived += OnLocalNotificationReceived;
         }
 
+        /// <summary>
+        /// Registers the given <seealso cref="AndroidNotificationChannel"/> for the Android
+        /// </summary>
+        public void RegisterChannel(GameNotificationChannel notificationChannel)
+        {
+            long[] vibrationPattern = null;
+            if (notificationChannel.VibrationPattern != null)
+            {
+                vibrationPattern = notificationChannel.VibrationPattern.Select(v => (long)v).ToArray();
+            }
+            
+            var channel = new AndroidNotificationChannel(notificationChannel.Id, notificationChannel.Name,
+                notificationChannel.Description, (Importance)notificationChannel.Style)
+            {
+                CanBypassDnd = notificationChannel.HighPriority,
+                CanShowBadge = notificationChannel.ShowsBadge,
+                EnableLights = notificationChannel.ShowLights,
+                EnableVibration = notificationChannel.Vibrates,
+                LockScreenVisibility = (LockScreenVisibility)notificationChannel.Privacy,
+                VibrationPattern = vibrationPattern
+            };
+
+            AndroidNotificationCenter.RegisterNotificationChannel(channel);
+        }
+
         /// <inheritdoc />
         /// <remarks>
         /// Will set the <see cref="AndroidGameNotification.Id"/> field of <paramref name="gameNotification"/>.

Runtime/GameNotificationsMonoBehaviour.cs

@@ -309,35 +309,17 @@ public void Initialize(params GameNotificationChannel[] channels)
 
             // Register the notification channels
             var doneDefault = false;
-            foreach (GameNotificationChannel notificationChannel in channels)
+            foreach (var notificationChannel in channels)
             {
+                var platform = _platform as AndroidNotificationsPlatform;
+                
                 if (!doneDefault)
                 {
                     doneDefault = true;
-                    ((AndroidNotificationsPlatform)_platform).DefaultChannelId = notificationChannel.Id;
+                    platform.DefaultChannelId = notificationChannel.Id;
                 }
 
-                long[] vibrationPattern = null;
-                if (notificationChannel.VibrationPattern != null)
-                {
-                    vibrationPattern = notificationChannel.VibrationPattern.Select(v => (long)v).ToArray();
-                }
-
-                // Wrap channel in Android object
-                var androidChannel = new AndroidNotificationChannel(
-                    notificationChannel.Id, notificationChannel.Name,
-                    notificationChannel.Description,
-                    (Importance)notificationChannel.Style)
-                {
-                    CanBypassDnd = notificationChannel.HighPriority,
-                    CanShowBadge = notificationChannel.ShowsBadge,
-                    EnableLights = notificationChannel.ShowLights,
-                    EnableVibration = notificationChannel.Vibrates,
-                    LockScreenVisibility = (LockScreenVisibility)notificationChannel.Privacy,
-                    VibrationPattern = vibrationPattern
-                };
-
-                AndroidNotificationCenter.RegisterNotificationChannel(androidChannel);
+                platform.RegisterChannel(notificationChannel);
             }
 #elif UNITY_IOS
             _platform = new iOSNotificationsPlatform();

package.json

@@ -1,7 +1,7 @@
 {
   "name": "com.gamelovers.notificationservice",
   "displayName": "Notification Service",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "unity": "2019.4",
   "description": "This package provides an easier to use service to help manage the notification sent to mobile devices, and based on the Unity's Mobile Notifications package.\nIt allows to schedule local notifications, receive remote notifications and clear any type of notification.",
   "dependencies": {