fix(core): 修复菜单节点缓存和异步线程安全问题

- 在 MenuSession 中添加节点缓存机制，避免菜单关闭后无法读取节点值
- 修改 HookPlaceholderAPI 中的 node 类型解析逻辑，使用新的缓存方法
- 在 RegisterCommands 中添加主线程检查，确保命令加载在主线程执行
- 更新在线玩家获取方式，使用 onlinePlayers 替代 Bukkit.getOnlinePlayers()
- 修复潜在的 ConcurrentModificationException 问题

Author: YsGqHY

.gitignore

@@ -1,3 +1,5 @@
 .gradle
 .idea
-build
+build
+.serena
+AGENTS.md

gradle.properties

@@ -1,2 +1,2 @@
 group=me.arasple.mc.trmenu
-version=3.9.21
+version=3.9.23

plugin/src/main/kotlin/trplugins/menu/module/display/Menu.kt

@@ -92,6 +92,7 @@ class Menu(
 
         if (menuOpenEvent.isCancelled) return
         session.menu = this
+        session.cacheNodes()
         block(session)
 
         if (!Metadata.byBukkit(viewer, "FORCE_OPEN") && !settings.openEvent.eval(adaptPlayer(session.viewer))) {

plugin/src/main/kotlin/trplugins/menu/module/display/MenuSession.kt

@@ -83,6 +83,9 @@ class MenuSession(
     // 临时任务（切换页码时允许删除）
     private val temporaries = mutableSetOf<PlatformExecutor.PlatformTask>()
 
+    // 缓存菜单节点，避免菜单关闭后无法读取
+    private var nodeCache: Map<String, Any?> = emptyMap()
+
     var locale: String = kotlin.run {
         if (langPlayer.isNotBlank()) {
             // Avoid ConcurrentModificationException
@@ -131,9 +134,7 @@ class MenuSession(
         val funced = FunctionParser.parse(placeholderPlayer, string) { type, value ->
             when (type) {
                 "node", "nodes", "n" -> parseNode(value) { key ->
-                    val config = menu?.conf ?: return@parseNode null
-                    val foundKey = config.getKeys(true).find { it.equals(key, ignoreCase = true) } ?: return@parseNode null
-                    config[foundKey]
+                    getNodeValue(key)
                 }
                 "lang" -> parseNode(value) { key ->
                     menu?.getLocaleValue(locale, key)
@@ -152,6 +153,21 @@ class MenuSession(
         return string.map { parse(it) }
     }
 
+    fun cacheNodes() {
+        val config = menu?.conf
+        nodeCache = config?.getKeys(true)?.associateBy({ it.lowercase() }) { config[it] } ?: emptyMap()
+    }
+
+    fun getNodeValue(key: String): Any? {
+        val normalizedKey = key.lowercase()
+        if (nodeCache.containsKey(normalizedKey)) {
+            return nodeCache[normalizedKey]
+        }
+        val config = menu?.conf ?: return null
+        val foundKey = config.getKeys(true).find { it.equals(key, ignoreCase = true) } ?: return null
+        return config[foundKey]
+    }
+
     private fun parseNode(node: String, valueSupplier: (String) -> Any?): String? {
         var key = node
         val arguments: Array<String>? = if (key.contains('_')) {

plugin/src/main/kotlin/trplugins/menu/module/internal/hook/ext/HookPlaceholderAPI.kt

@@ -39,7 +39,7 @@ object HookPlaceholderAPI : PlaceholderExpansion {
             "meta" -> Metadata.getMeta(player)[key]
             "data" -> Metadata.getData(player)[key]
             "globaldata" -> runCatching { Metadata.globalData[value()].toString() }.getOrElse { "null" }
-            "node" -> session.menu?.conf?.let { it[it.ignoreCase(value())].toString() }.toString()
+            "node" -> session.getNodeValue(value())?.toString() ?: "null"
             "menu" -> menu(session, params)
             "locale" -> session.locale
             "js" -> if (enabledParseJavaScript) if (params.size > 1) JavaScriptAgent.eval(session, params[1]).asString() else "" else "UNABLE_PARSE"
@@ -75,4 +75,4 @@ object HookPlaceholderAPI : PlaceholderExpansion {
         }
     }
 
-}
+}

plugin/src/main/kotlin/trplugins/menu/module/internal/service/RegisterCommands.kt

@@ -7,6 +7,7 @@ import taboolib.common.platform.command.command
 import taboolib.common.platform.function.adaptPlayer
 import taboolib.common.platform.function.submit
 import taboolib.common.platform.function.unregisterCommand
+import taboolib.platform.util.onlinePlayers
 import trplugins.menu.TrMenu
 import trplugins.menu.TrMenu.actionHandle
 import trplugins.menu.api.reaction.Reactions
@@ -26,6 +27,12 @@ object RegisterCommands {
     }
 
     fun load() {
+        if (!Bukkit.isPrimaryThread()) {
+            submit {
+                load()
+            }
+            return
+        }
         val unregisterList = registered.toList()
         unregisterList.forEach { unregisterCommand(it) }
         registered.clear()
@@ -78,7 +85,7 @@ object RegisterCommands {
         // 延迟同步命令到所有在线玩家，避免与 Paper 异步命令发送线程冲突
         // Paper 的 sendAsync 会在异步线程遍历命令树，直接调用 updateCommands 可能触发 ConcurrentModificationException
         submit(delay = 1) {
-            val players = Bukkit.getOnlinePlayers()
+            val players = onlinePlayers
             if (players.isEmpty()) {
                 return@submit
             }