moved things out of ctor into 1st validation call

Author: stesee

PDfAValidatorTest/PdfAValidatorTest.cs

@@ -13,6 +13,7 @@ public static void ShouldUnpackNewDirectoryInTempdirectory()
             var listOfDirectoriesInTempWithoutVeraPdf = Directory.GetDirectories(Path.GetTempPath());
             using (var pdfAValidator = new PdfAValidator.PdfAValidator())
             {
+                pdfAValidator.Validate(@"./TestPdfFiles/FromLibreOffice.pdf");
                 AssertVeraPdfBinCreation(listOfDirectoriesInTempWithoutVeraPdf, pdfAValidator);
             }
             var listOfDirectoriesInTempAfterVeraPdf = Directory.GetDirectories(Path.GetTempPath());
@@ -72,12 +73,15 @@ public static void ShouldWorkWithCustomJavaAndVeraPdfLocation()
             var listOfDirectoriesInTempWithoutVeraPdf = Directory.GetDirectories(Path.GetTempPath());
             using (var pdfAValidatorPrepareBins = new PdfAValidator.PdfAValidator())
             {
-                using (var pdfAValidator = new PdfAValidator.PdfAValidator(pdfAValidatorPrepareBins.VeraPdfStartScript, pdfAValidatorPrepareBins.PathJava))
                 {
-                    AssertVeraPdfBinCreation(listOfDirectoriesInTempWithoutVeraPdf, pdfAValidator);
-                    Assert.True(File.Exists(@"./TestPdfFiles/FromLibreOfficeNonPdfA.pdf"));
-                    var result = pdfAValidator.Validate(@"./TestPdfFiles/FromLibreOfficeNonPdfA.pdf");
-                    Assert.False(result);
+                    pdfAValidatorPrepareBins.Validate(@"./TestPdfFiles/FromLibreOfficeNonPdfA.pdf");
+                    using (var pdfAValidator = new PdfAValidator.PdfAValidator(pdfAValidatorPrepareBins.VeraPdfStartScript, pdfAValidatorPrepareBins.PathJava))
+                    {
+                        AssertVeraPdfBinCreation(listOfDirectoriesInTempWithoutVeraPdf, pdfAValidator);
+                        Assert.True(File.Exists(@"./TestPdfFiles/FromLibreOfficeNonPdfA.pdf"));
+                        var result = pdfAValidator.Validate(@"./TestPdfFiles/FromLibreOfficeNonPdfA.pdf");
+                        Assert.False(result);
+                    }
                 }
             }
             var listOfDirectoriesInTempAfterVeraPdf = Directory.GetDirectories(Path.GetTempPath());

PdfAValidator/PdfAValidator.cs

@@ -8,7 +8,6 @@
 using System.Xml.Serialization;
 
 // TODO Fix the generated casing in report.cs
-// TODO Move stuff out of ctor
 
 namespace PdfAValidator
 {
@@ -17,6 +16,23 @@ namespace PdfAValidator
     /// </summary>
     public class PdfAValidator : IDisposable
     {
+        private const string maskedQuote = "\"";
+        private string _pathVeraPdfDirectory;
+        /// <summary>
+        /// Path to java jre used by windows
+        /// </summary>
+        /// <value></value>
+        public string PathJava { private set; get; }
+
+        private readonly bool _customVerapdfAndJavaLocations;
+
+        private bool isInitilized { get; set; }
+
+        /// <summary>
+        /// Command that is used to invoke VeraPdf 
+        /// </summary>
+        /// <value>Command with arguments</value>
+        public string VeraPdfStartScript { private set; get; }
         /// <summary>
         /// Disposing verapdf bins
         /// </summary>
@@ -27,7 +43,6 @@ public void Dispose()
                 Directory.Delete(_pathVeraPdfDirectory, true);
             }
         }
-
         /// <summary>
         /// Use this constructor to use your own installation of VeraPdf and Java, e.g.: c:\somePath\verapdf.bat
         /// </summary>
@@ -38,28 +53,16 @@ public PdfAValidator(string pathToVeraPdfBin, string pathToJava)
             VeraPdfStartScript = pathToVeraPdfBin;
             PathJava = pathToJava;
             _customVerapdfAndJavaLocations = true;
+            isInitilized = true;
         }
 
         /// <summary>
         /// Use this constructor to use the embedded veraPdf binaries
         /// </summary>
         public PdfAValidator()
-        { intiPathToVeraPdfBinAndJava(); }
+        { }
 
-        private const string maskedQuote = "\"";
-        private string _pathVeraPdfDirectory;
-        /// <summary>
-        /// Path to java jre used by windows
-        /// </summary>
-        /// <value></value>
-        public string PathJava { private set; get; }
 
-        private readonly bool _customVerapdfAndJavaLocations;
-        /// <summary>
-        /// 
-        /// </summary>
-        /// <value></value>
-        public string VeraPdfStartScript { private set; get; }
         /// <summary>
         /// Validates a pdf to be compliant with the pdfa standard claimed by its meta data
         /// </summary>
@@ -76,6 +79,7 @@ public bool Validate(string pathToPdfFile)
         /// <returns></returns>
         public report ValidateWithDetailedReport(string pathToPdfFile)
         {
+            intiPathToVeraPdfBinAndJava();
             var absolutePathToPdfFile = Path.GetFullPath(pathToPdfFile);
 
             if (!File.Exists(absolutePathToPdfFile))
@@ -131,10 +135,13 @@ private static T DeserializeXml<T>(string sourceXML) where T : class
                 result = (T)serializer.Deserialize(reader);
             return result;
         }
-
-
         private void intiPathToVeraPdfBinAndJava()
         {
+            if (isInitilized)
+            {
+                return;
+            }
+
             _pathVeraPdfDirectory = Path.Combine(Path.GetTempPath(), "VeraPdf" + Guid.NewGuid());
             Directory.CreateDirectory(_pathVeraPdfDirectory);
 
@@ -155,6 +162,7 @@ private void intiPathToVeraPdfBinAndJava()
             {
                 throw new NotImplementedException("Sorry, only supporting linux and windows.");
             }
+            isInitilized = true;
         }
 
         private static void SetLinuxFileExecuteable(string filePath)

PdfAValidator/PdfAValidator.csproj

@@ -7,9 +7,9 @@
     <PackageTags>Pdf PdfA VeraPdf Pdf/A</PackageTags>
     <Authors>Stefan Seeland</Authors>
     <Company>Codeuctivity</Company>
-    <AssemblyVersion>1.0.0.20</AssemblyVersion>
-    <FileVersion>1.0.0.20</FileVersion>
-    <Version>1.0.20</Version>
+    <AssemblyVersion>1.0.0.21</AssemblyVersion>
+    <FileVersion>1.0.0.21</FileVersion>
+    <Version>1.0.21</Version>
     <PackageIconUrl>https://avatars3.githubusercontent.com/u/8453155?v=2&amp;s=200</PackageIconUrl>
     <PackageProjectUrl>https://github.com/Codeuctivity/PdfAValidatorApi</PackageProjectUrl>
     <Description>PdfAValidator is based on VeraPdf and is an open source conformance checker for PDF/A files. It is designed to help archives and libraries check that their PDF/A collections conform to the appropriate ISO 19005 archiving standard specification.</Description>