more code style

Author: stesee

PdfAValidator/PdfAValidator.cs

@@ -8,8 +8,6 @@
 using System.Xml.Serialization;
 
 // TODOS:
-// Performance - now every call causes verapdf to be unpacked
-// Codestyle - make this code great again
 // Fix the generated casing in report.cs
 
 namespace PdfAValidator
@@ -40,7 +38,6 @@ public PdfAValidator()
 
         private string _pathVeraPdfDirectory;
         public string PathJava { private set; get; }
-        private string _pathZipVeraPdf;
         public string VeraPdfStarterScript { private set; get; }
 
         public bool Validate(string pathToPdfFile)
@@ -131,32 +128,32 @@ private void intiPathToVeraPdfBinAndJava()
         {
             _pathVeraPdfDirectory = Path.Combine(Path.GetTempPath(), "VeraPdf" + Guid.NewGuid());
             Directory.CreateDirectory(_pathVeraPdfDirectory);
-            _pathZipVeraPdf = Path.Combine(_pathVeraPdfDirectory, "VeraPdf.zip");
+            var pathZipVeraPdf = Path.Combine(_pathVeraPdfDirectory, "VeraPdf.zip");
 
             var assembly = Assembly.GetExecutingAssembly();
 
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
                 using (var stream = assembly.GetManifestResourceStream("PdfAValidator.VeraPdf.Windows.zip"))
-                using (var fileStream = File.Create(_pathZipVeraPdf))
+                using (var fileStream = File.Create(pathZipVeraPdf))
                 {
                     stream.Seek(0, SeekOrigin.Begin);
                     stream.CopyTo(fileStream);
                 }
-                ZipFile.ExtractToDirectory(_pathZipVeraPdf, _pathVeraPdfDirectory);
+                ZipFile.ExtractToDirectory(pathZipVeraPdf, _pathVeraPdfDirectory);
                 VeraPdfStarterScript = Path.Combine(_pathVeraPdfDirectory, "verapdf", "verapdf.bat");
                 // took from https://adoptopenjdk.net/releases.html?variant=openjdk8&jvmVariant=hotspot#x64_win
                 PathJava = Path.Combine(_pathVeraPdfDirectory, "verapdf", "jdk8u202-b08-jre", "bin", "java");
             }
             else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
             {
                 using (var stream = assembly.GetManifestResourceStream("PdfAValidator.VeraPdf.Linux.zip"))
-                using (var fileStream = File.Create(_pathZipVeraPdf))
+                using (var fileStream = File.Create(pathZipVeraPdf))
                 {
                     stream.Seek(0, SeekOrigin.Begin);
                     stream.CopyTo(fileStream);
                 }
-                ZipFile.ExtractToDirectory(_pathZipVeraPdf, _pathVeraPdfDirectory);
+                ZipFile.ExtractToDirectory(pathZipVeraPdf, _pathVeraPdfDirectory);
 
                 VeraPdfStarterScript = Path.Combine(_pathVeraPdfDirectory, "verapdf", "verapdf");
                 SetLinuxFileExecuteable(VeraPdfStarterScript);

README.md

@@ -9,33 +9,33 @@ Install it using nuget package [PdfAValidatorApi](https://www.nuget.org/packages
 
     Install-Package PdfAValidator
 
-Sample - e.g. use it in your unit test to check compliance of some pdf: 
+Sample - e.g. use it in your unit test to check compliance of some pdf:
 
 ```C#
-[Fact]
- public void ShouldDetectCompliantPdfA()
- {
-     using (var pdfAValidator = new PdfAValidator.PdfAValidator())
+    [Fact]
+     public void ShouldDetectCompliantPdfA()
      {
-         var result = pdfAValidator.Validate(@"./TestPdfFiles/FromLibreOffice.pdf");
-         Assert.True(result);
+         using (var pdfAValidator = new PdfAValidator.PdfAValidator())
+         {
+             var result = pdfAValidator.Validate(@"./TestPdfFiles/FromLibreOffice.pdf");
+             Assert.True(result);
+         }
      }
- }
 ```
 
-Sample - e.g. use it in your unit test to check the used sub standard of some pdf: 
+Sample - e.g. use it in your unit test to check the used sub standard of some pdf:
 
 ```C#
-[Fact]
- public void ShouldGetDetailedReportFromPdfA()
- {
-     using (var pdfAValidator = new PdfAValidator.PdfAValidator())
+    [Fact]
+     public void ShouldGetDetailedReportFromPdfA()
      {
-         var result = pdfAValidator.ValidateWithDetailedReport(@"./TestPdfFiles/FromLibreOffice.pdf");
-         Assert.True(result.jobs.job.validationReport.isCompliant);
-         Assert.True(result.jobs.job.validationReport.profileName == "PDF/A-1A validation profile");
+         using (var pdfAValidator = new PdfAValidator.PdfAValidator())
+         {
+             var result = pdfAValidator.ValidateWithDetailedReport(@"./TestPdfFiles/FromLibreOffice.pdf");
+             Assert.True(result.jobs.job.validationReport.isCompliant);
+             Assert.True(result.jobs.job.validationReport.profileName == "PDF/A-1A validation profile");
+         }
      }
- }
 ```
 
 [![NuGet Status](http://nugetstatus.com/PdfAValidator.png)](http://nugetstatus.com/packages/PdfAValidator)