fix: Increase test coverage

Author: jdehaan

Makefile

@@ -3,7 +3,7 @@
 # Build command with common flags
 BUILD_CMD = CGO_ENABLED=0 go build -trimpath -ldflags="-s -w" -tags=prod
 PACKAGE = ./backup/main.go
-COVERAGE_THRESHOLD = 90
+COVERAGE_THRESHOLD = 98
 
 .PHONY: build clean test lint tidy checksums release sanity-check check-mod-tidy lint-config-check  lint-fix format check-clean check-coverage
 

backup/internal/test/check_test.go

@@ -281,3 +281,57 @@ func TestListUncoveredPaths_UnreadableDirectory(t *testing.T) {
 	assert.Equal(t, []string{"/data"}, result)
 	assert.Contains(t, logBuf.String(), "ADD: Path '/data' is uncovered")
 }
+
+// Test that a child path matching a job exclusion is marked as excluded
+// (covers isExcluded true + isCoveredByJob excluded log).
+func TestListUncoveredPaths_ChildPathExcludedByJob(t *testing.T) {
+	fs := afero.NewMemMapFs()
+	_ = fs.MkdirAll("/data/stuff/docs", 0755)
+	_ = fs.MkdirAll("/data/stuff/cache", 0755)
+
+	var logBuf bytes.Buffer
+
+	checker := newTestChecker(fs, &logBuf)
+
+	cfg := Config{
+		Sources: []Path{
+			{Path: "/data/stuff"},
+		},
+		Jobs: []Job{
+			// Source "/data" with exclusion "stuff/cache" so exclusionPath = "/data/stuff/cache"
+			{Name: "data-backup", Source: "/data", Exclusions: []string{"stuff/cache"}},
+			// Covers the /data/stuff/docs child directly
+			{Name: "docs", Source: "/data/stuff/docs"},
+		},
+	}
+
+	result := checker.ListUncoveredPaths(cfg)
+
+	assert.Empty(t, result)
+	assert.Contains(t, logBuf.String(), "EXCLUDED: Path '/data/stuff/cache' is excluded by job 'data-backup'")
+}
+
+// Test that a source path that is globally excluded is skipped in checkPath.
+func TestListUncoveredPaths_GloballyExcludedSourceSkipped(t *testing.T) {
+	fs := afero.NewMemMapFs()
+	_ = fs.MkdirAll("/data/cache", 0755)
+
+	var logBuf bytes.Buffer
+
+	checker := newTestChecker(fs, &logBuf)
+
+	cfg := Config{
+		Sources: []Path{
+			{Path: "/data", Exclusions: []string{"cache"}},
+			{Path: "/data/cache"},
+		},
+		Jobs: []Job{
+			{Name: "backup", Source: "/data"},
+		},
+	}
+
+	result := checker.ListUncoveredPaths(cfg)
+
+	assert.Empty(t, result)
+	assert.Contains(t, logBuf.String(), "SKIP: Path '/data/cache' is globally excluded")
+}

backup/internal/test/config_test.go

@@ -452,6 +452,50 @@ jobs:
 	assert.Contains(t, err.Error(), "job source path validation failed")
 }
 
+func TestLoadResolvedConfig_OverlappingSourcePathsAllowedByExclusion(t *testing.T) {
+	yaml := `
+sources:
+  - path: "/home"
+targets:
+  - path: "/backup"
+jobs:
+  - name: "parent"
+    source: "/home/user"
+    target: "/backup/user"
+    exclusions:
+      - "docs"
+  - name: "child"
+    source: "/home/user/docs"
+    target: "/backup/docs"
+`
+	path := writeTestConfig(t, yaml)
+
+	cfg, err := LoadResolvedConfig(path)
+	require.NoError(t, err)
+	assert.Len(t, cfg.Jobs, 2)
+}
+
+func TestLoadResolvedConfig_OverlappingTargetPaths(t *testing.T) {
+	yaml := `
+sources:
+  - path: "/home"
+targets:
+  - path: "/backup"
+jobs:
+  - name: "job1"
+    source: "/home/docs"
+    target: "/backup/all"
+  - name: "job2"
+    source: "/home/photos"
+    target: "/backup/all/photos"
+`
+	path := writeTestConfig(t, yaml)
+
+	_, err := LoadResolvedConfig(path)
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "job target path validation failed")
+}
+
 func TestLoadResolvedConfig_ValidConfig(t *testing.T) {
 	yaml := `
 sources:

backup/internal/test/helper_test.go

@@ -1,6 +1,7 @@
 package internal_test
 
 import (
+	"os"
 	"testing"
 	"time"
 
@@ -78,3 +79,36 @@ func TestCreateMainLogger_DeterministicLogPath_NoSimulate(t *testing.T) {
 
 	assert.Equal(t, "logs/sync-2025-06-15T14-30-45-sync", logPath)
 }
+
+func TestCreateMainLogger_MkdirError(t *testing.T) {
+	// Use t.Chdir to a temp dir so we control the filesystem
+	tmpDir := t.TempDir()
+	t.Chdir(tmpDir)
+
+	// Create "logs" as a regular file to block MkdirAll
+	err := os.WriteFile("logs", []byte("block"), 0600)
+	require.NoError(t, err)
+
+	_, _, cleanup, err := CreateMainLogger("test.yaml", false, fixedTime())
+	_ = cleanup
+
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "failed to create log directory")
+}
+
+func TestCreateMainLogger_OpenFileError(t *testing.T) {
+	tmpDir := t.TempDir()
+	t.Chdir(tmpDir)
+
+	// Pre-create the log path directory and make summary.log a directory to block OpenFile
+	logDir := "logs/sync-2025-06-15T14-30-45-test"
+
+	err := os.MkdirAll(logDir+"/summary.log", 0750)
+	require.NoError(t, err)
+
+	_, _, cleanup, err := CreateMainLogger("test.yaml", false, fixedTime())
+	_ = cleanup
+
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "failed to open overall log file")
+}

backup/internal/test/job_test.go

@@ -5,6 +5,8 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"gopkg.in/yaml.v3"
 )
 
 func newJob() Job {
@@ -56,3 +58,18 @@ func TestApply_JobSucceeds_RunIsCalledAndReturnsSuccess(t *testing.T) {
 
 	assert.Equal(t, Success, status)
 }
+
+func TestUnmarshalYAML_InvalidNode(t *testing.T) {
+	// A scalar node cannot be decoded into the JobYAML struct
+	node := &yaml.Node{
+		Kind:  yaml.ScalarNode,
+		Value: "not a mapping",
+	}
+
+	var job Job
+
+	err := node.Decode(&job)
+
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "failed to decode YAML node")
+}