Skip to content

Commit 53da5d7

Browse files
committed
Upgrade simple-http-request-builder
1 parent 6b74d67 commit 53da5d7

File tree

4 files changed

+17
-30
lines changed

4 files changed

+17
-30
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
},
3939
"sideEffects": false,
4040
"dependencies": {
41-
"simple-http-request-builder": "^1.0.1",
41+
"simple-http-request-builder": "^2.0.0",
4242
"simple-logging-system": "^1.1.0"
4343
},
4444
"devDependencies": {

src/tests/ApiHttpClient.ts

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,21 @@
11
import { HttpRequest, HttpMethod } from 'simple-http-request-builder';
2-
import { unwrapHttpPromise, HttpPromise } from '../lib/promise/HttpPromise';
2+
import { HttpPromise } from '../lib/promise/HttpPromise';
33
import { defaultJsonFetchClient } from '../lib/client/JsonFetchClient';
4-
import { fetchClient } from '../lib/client/FetchClient';
4+
import {
5+
createHttpFetchRequest,
6+
fetchClient,
7+
} from '../lib/client/FetchClient';
58

6-
const baseUrl = '/api';
9+
const baseUrl = 'https://hostname/api';
710

811
export default class ApiHttpClient {
912
// eslint-disable-next-line class-methods-use-this
1013
rawRequest(method: HttpMethod, path: string): HttpRequest<HttpPromise<Response>> {
11-
return new HttpRequest<HttpPromise<Response>>(
12-
(httpRequest) => new HttpPromise<Response>(
13-
unwrapHttpPromise(fetchClient(httpRequest)),
14-
httpRequest,
15-
),
16-
baseUrl,
17-
method,
18-
path,
19-
);
14+
return createHttpFetchRequest(baseUrl, method, path, fetchClient);
2015
}
2116

2217
// eslint-disable-next-line class-methods-use-this
2318
restRequest<T>(method: HttpMethod, path: string): HttpRequest<HttpPromise<T>> {
24-
return new HttpRequest<HttpPromise<T>>(
25-
(httpRequest) => new HttpPromise<T>(
26-
unwrapHttpPromise(defaultJsonFetchClient(httpRequest)),
27-
httpRequest,
28-
),
29-
baseUrl,
30-
method,
31-
path,
32-
);
19+
return createHttpFetchRequest(baseUrl, method, path, defaultJsonFetchClient);
3320
}
3421
}

src/tests/FetchClient.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe('Tests fetch client', () => {
4444
test('Check simple request sample', async () => {
4545
setMockedBody({ test: 1 });
4646
const response = await new ApiHttpClient()
47-
.rawRequest(HttpMethod.GET, '/users')
47+
.rawRequest(HttpMethod.GET, 'https://hostname/users')
4848
.execute()
4949
.toPromise();
5050
expect(response.status).toBe(200);
@@ -57,7 +57,7 @@ describe('Tests fetch client', () => {
5757
test('Check network error rejects promise with networkError', async () => {
5858
mockedPromiseError = new Error();
5959
const response = new ApiHttpClient()
60-
.rawRequest(HttpMethod.GET, '/users')
60+
.rawRequest(HttpMethod.GET, 'https://hostname/users')
6161
.execute()
6262
.toPromise();
6363
await expect(response).rejects.toEqual(networkError);
@@ -67,7 +67,7 @@ describe('Tests fetch client', () => {
6767
mockedPromiseError = new Error();
6868
mockedPromiseError.name = 'AbortError';
6969
const response = new ApiHttpClient()
70-
.rawRequest(HttpMethod.GET, '/users')
70+
.rawRequest(HttpMethod.GET, 'https://hostname/users')
7171
.execute()
7272
.toPromise();
7373
await expect(response).rejects.toEqual(timeoutError);

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6371,10 +6371,10 @@ __metadata:
63716371
languageName: node
63726372
linkType: hard
63736373

6374-
"simple-http-request-builder@npm:^1.0.1":
6375-
version: 1.0.1
6376-
resolution: "simple-http-request-builder@npm:1.0.1"
6377-
checksum: 3294ed107a11ce1aea4052233ec06509e9bf5d4d87f0daaf38379c43626f706267410ed770aeb2ddd3bcb4818e557bd7dafa41d17fb3df5a58f7c1a8a1545465
6374+
"simple-http-request-builder@npm:^2.0.0":
6375+
version: 2.0.0
6376+
resolution: "simple-http-request-builder@npm:2.0.0"
6377+
checksum: ac7f993f05d0247a62de6dd4b718d3ab9d4ad5025a35197f13cd93c120fb427c3ae3f7d82fbeadc8018927833f4cdfaba680d6d0d7fdda7373cf606b7644497d
63786378
languageName: node
63796379
linkType: hard
63806380

@@ -6396,7 +6396,7 @@ __metadata:
63966396
jest-config: ^27.5.1
63976397
node-fetch: 2
63986398
release-it: ^15.1.0
6399-
simple-http-request-builder: ^1.0.1
6399+
simple-http-request-builder: ^2.0.0
64006400
simple-logging-system: ^1.1.0
64016401
source-map-support: ^0.5.21
64026402
ts-jest: ^27.1.4

0 commit comments

Comments
 (0)