From 6fde142e6d3e996a6d12d8d35c4ef0ab7d792498 Mon Sep 17 00:00:00 2001 From: Rob Paskin Date: Thu, 28 Jun 2018 12:01:43 +0100 Subject: [PATCH 1/3] Amend Rubocop config based on running it on GPS --- rubocop.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rubocop.yml b/rubocop.yml index 7de2eb3..e77b679 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -99,6 +99,13 @@ Style/AndOr: Style/BlockDelimiters: EnforcedStyle: 'semantic' + IgnoredMethods: + - it + - lambda + - proc + # Rails Controller `format` methods in `respond_to` blocks + - html + - js Style/ClassAndModuleChildren: EnforcedStyle: 'compact' From 0374c0ed7c4dbe1d470b003c34f26c663de79519 Mon Sep 17 00:00:00 2001 From: Rob Paskin Date: Thu, 28 Jun 2018 13:20:01 +0100 Subject: [PATCH 2/3] Further amendments to Rubocop config based on GPS --- rubocop.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rubocop.yml b/rubocop.yml index e77b679..ff7c4fe 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -99,8 +99,14 @@ Style/AndOr: Style/BlockDelimiters: EnforcedStyle: 'semantic' + Exclude: + - 'spec/*_helper.rb' + - 'spec/factories/**/*.rb' + - 'spec/support/factories/**/*.rb' + - 'spec_legacy/factory_girl/**/*.rb' IgnoredMethods: - it + - default_scope - lambda - proc # Rails Controller `format` methods in `respond_to` blocks From ca0d668b923ab4ecafc749891985e8d6298e6578 Mon Sep 17 00:00:00 2001 From: Rob Paskin Date: Fri, 29 Jun 2018 15:43:55 +0100 Subject: [PATCH 3/3] Add more filename exclusions from FlightPlan --- rubocop.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rubocop.yml b/rubocop.yml index ff7c4fe..7ea4c70 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -2,6 +2,8 @@ AllCops: Exclude: - 'db/**/*' + - 'node_modules/**/*' + - 'tmp/**/*' inherit_mode: merge: