fix for #36 23.976 DF codes

Author: m1tk4

README.md

@@ -100,6 +100,8 @@ To run the tests in a browser environment, open the `test/smpte-timecode-test.ht
 in a browser.
 
 ## Update History
+- 1.3.3
+  - fix for #36 - 23.976 is never a drop frame timecode.
 - 1.3.2
   - fixed to browser-based tests, documentation.
 - 1.3.1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "smpte-timecode",
-  "version": "1.3.2",
+  "version": "1.3.3",
   "description": "JavaScript implementation of SMPTE timecode type",
   "main": "smpte-timecode.js",
   "scripts": {

smpte-timecode.js

@@ -46,7 +46,7 @@
                         // we got a fractional, we'll assume it's a 29.97, 23.98, 59.94 or something of the sort
                         this.frameRateNum = frameRateRound*1000;
                         this.frameRateDen = 1001;
-                        this.dropFrame = true;
+                        if (frameRateRound != 24) this.dropFrame = true;
                     }
                 }
                 break;
@@ -69,7 +69,7 @@
             this.seconds = parseInt(parts[3]);
             // do not override input parameters
             if (typeof dropFrame !== 'boolean') {
-                this.dropFrame = parts[4]!==':';
+                this.dropFrame = ( parts[4]!==':' && this.frameRate>25 );
             }
             this.frames = parseInt(parts[5]);
             this._timeCodeToFrameCount();

test/smpte-timecode-test.js

@@ -276,3 +276,12 @@ describe('DST handling', function() {
     });
 
 });
+
+describe('Issues', function() {
+    it ('#36 23.976 Time Code', function(){
+        var t = new Timecode("10:00:00;06", 23.976, false); 
+        expect(t.dropFrame).to.be(false);
+        var t1 = new Timecode("10:00:00;06", 23.976); 
+        expect(t1.dropFrame).to.be(false);
+    });
+});