This repository was archived by the owner on Sep 22, 2025. It is now read-only.
Chess #9
Open
Chess #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subject to change.
…exed only as a 2D array
…he first index in valid moves list
…default settings.
…e been implemented (the ugly way), which may be improved in a future version.
…ying the esisting reference.
…in Load/Remove saves screen
Contributor
webmaster442
left a comment
webmaster442
left a comment
There was a problem hiding this comment.
- Dependency Inversion és interface segregation ✅
- Külön JSON DTO-k ✅
- Egyedi Struct helyesen használva ✅
- A figurák UTF értékei helyett lehetett volna konstansban tárolni őket nevesítve. 🤔
Szép és összetett munka, látszik, hogy sokat dolgoztál vele. Bőven teljesíti az elvárásokat és nem tudok belekötni.
| } | ||
| public override string ToString() | ||
| { | ||
| return " \u265d "; |
Contributor
There was a problem hiding this comment.
UTF Nice. Btw ez lehetett volna egy constants osztályba ahonnan behivatkozod névvel, mert a Black Chess Bishop többet mond, mint a \u265d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Egy kisebb és átláthatóbb projektet kellett volna csinálnom😢