fix: fix returnId serialized boolean into "true"/"false" #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello @runeanielsen, could you please review this small fix? Happy to actually contribute to this project ✋ |
Member
|
Hi @rahadiankp I'll take a look at it soon. I've been a bit busy lately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly calling
Boolean.ToString()or$"{Boolean}"would result in string of either "True" or "False", instead of "true" or "false."This PR is raised because when I tried to use non-null
returnIdparam forImportDocuments, I got an error from Typesense saying the accepted values aretrueorfalseonly.This PR attempts to fix this issue.