From 2fb47a3c8f6be9f543e8e26bf8c8a70e9828fab3 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 10:39:24 +0200 Subject: [PATCH 01/11] Dummy to try reproducing failing CI --- dummy.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 dummy.txt diff --git a/dummy.txt b/dummy.txt new file mode 100644 index 0000000..3621550 --- /dev/null +++ b/dummy.txt @@ -0,0 +1 @@ +# some dummy change From 804c7312660b476914491db47f580b00b939021a Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 10:45:17 +0200 Subject: [PATCH 02/11] Test revert of crate-ci/typos script --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 00a9370..731d939 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -10,4 +10,4 @@ jobs: - name: Checkout Actions Repository uses: actions/checkout@v4 - name: Check spelling - uses: crate-ci/typos@v1.31.2 + uses: crate-ci/typos@v1.29.0 From 91aeabba88eddb596c8fb2aca6e3336d6470cafe Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 10:48:10 +0200 Subject: [PATCH 03/11] Run only parallel tests --- test/runtests.jl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index 9ca3763..faa806e 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -22,11 +22,11 @@ import MPIPreferences @info "Finished parallel tests" end - @time @testset "serial" begin - @info "Starting serial tests" + # @time @testset "serial" begin + # @info "Starting serial tests" - include("test_all.jl") + # include("test_all.jl") - @info "Finished serial tests" - end + # @info "Finished serial tests" + # end end From 2c55a0c5b15da4e1bd86f542343030816a26daef Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 11:00:13 +0200 Subject: [PATCH 04/11] Add back serial tests --- test/runtests.jl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index faa806e..9ca3763 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -22,11 +22,11 @@ import MPIPreferences @info "Finished parallel tests" end - # @time @testset "serial" begin - # @info "Starting serial tests" + @time @testset "serial" begin + @info "Starting serial tests" - # include("test_all.jl") + include("test_all.jl") - # @info "Finished serial tests" - # end + @info "Finished serial tests" + end end From a2890eaedf1e95d95a2e992c4e41f246b623e5f9 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 11:07:00 +0200 Subject: [PATCH 05/11] Only parallel, but new typo script --- .github/workflows/SpellCheck.yml | 2 +- test/runtests.jl | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 731d939..00a9370 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -10,4 +10,4 @@ jobs: - name: Checkout Actions Repository uses: actions/checkout@v4 - name: Check spelling - uses: crate-ci/typos@v1.29.0 + uses: crate-ci/typos@v1.31.2 diff --git a/test/runtests.jl b/test/runtests.jl index 9ca3763..faa806e 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -22,11 +22,11 @@ import MPIPreferences @info "Finished parallel tests" end - @time @testset "serial" begin - @info "Starting serial tests" + # @time @testset "serial" begin + # @info "Starting serial tests" - include("test_all.jl") + # include("test_all.jl") - @info "Finished serial tests" - end + # @info "Finished serial tests" + # end end From 980785d70b10e93da607869a214c25748fed8d92 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 11:22:32 +0200 Subject: [PATCH 06/11] Activate serial but deactivate forest test --- test/runtests.jl | 10 +++++----- test/test_all.jl | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index faa806e..9ca3763 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -22,11 +22,11 @@ import MPIPreferences @info "Finished parallel tests" end - # @time @testset "serial" begin - # @info "Starting serial tests" + @time @testset "serial" begin + @info "Starting serial tests" - # include("test_all.jl") + include("test_all.jl") - # @info "Finished serial tests" - # end + @info "Finished serial tests" + end end diff --git a/test/test_all.jl b/test/test_all.jl index c093ac3..a7f2a97 100644 --- a/test/test_all.jl +++ b/test/test_all.jl @@ -31,8 +31,8 @@ end include("cmesh/test_readmshfile.jl") end -@testset "forest" begin - include("forest/test_element_volume.jl") -end +# @testset "forest" begin +# include("forest/test_element_volume.jl") +# end end # module From e507cb92d1053d239103e74e1e5c81c78f663621 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 11:28:43 +0200 Subject: [PATCH 07/11] Test different test --- test/test_all.jl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/test_all.jl b/test/test_all.jl index a7f2a97..1b86d62 100644 --- a/test/test_all.jl +++ b/test/test_all.jl @@ -27,12 +27,12 @@ end include("test_forestwrapper.jl") end -@testset "cmesh" begin - include("cmesh/test_readmshfile.jl") -end - -# @testset "forest" begin -# include("forest/test_element_volume.jl") +# @testset "cmesh" begin +# include("cmesh/test_readmshfile.jl") # end +@testset "forest" begin + include("forest/test_element_volume.jl") +end + end # module From b6ad92d3e7e9e8f3457578a376aff28b46cc6b7a Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 13:15:01 +0200 Subject: [PATCH 08/11] Deactivate two cmeshes --- test/cmesh/test_readmshfile.jl | 54 +++++++++++++++++++++------------- test/test_all.jl | 6 ++-- 2 files changed, 37 insertions(+), 23 deletions(-) diff --git a/test/cmesh/test_readmshfile.jl b/test/cmesh/test_readmshfile.jl index 94d6729..a0ecfaf 100644 --- a/test/cmesh/test_readmshfile.jl +++ b/test/cmesh/test_readmshfile.jl @@ -81,12 +81,18 @@ end t8_supported_msh_file(cmesh) t8_cmesh_destroy(Ref(cmesh)) + + + println("Hello 4!") end @testset "test_msh_file_vers4_ascii" begin fileprefix = "cmesh/testfiles/test_msh_file_vers4_ascii" filename = fileprefix * ".msh" + + println("Hello 3!") + @assert isfile(filename) "File not found: "*filename cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) @@ -94,35 +100,43 @@ end @assert cmesh!=C_NULL "Could not read cmesh from ascii version 4, but should be able to: "*filename t8_cmesh_destroy(Ref(cmesh)) + end - @testset "test_msh_file_vers2_bin" begin - fileprefix = "cmesh/testfiles/test_msh_file_vers2_bin" - filename = fileprefix * ".msh" + # @testset "test_msh_file_vers2_bin" begin - @assert isfile(filename) "File not found: "*filename - cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) + # println("Hello!") + # fileprefix = "cmesh/testfiles/test_msh_file_vers2_bin" + # filename = fileprefix * ".msh" - @assert cmesh==C_NULL "Expected fail of reading binary msh file v.2, but did not fail." + # @assert isfile(filename) "File not found: "*filename - if cmesh != C_NULL - t8_cmesh_destroy(Ref(cmesh)) - end - end + # cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) - @testset "test_msh_file_vers4_bin" begin - fileprefix = "cmesh/testfiles/test_msh_file_vers4_bin" - filename = fileprefix * ".msh" + # @assert cmesh==C_NULL "Expected fail of reading binary msh file v.2, but did not fail." - @assert isfile(filename) "File not found: "*filename + # if cmesh != C_NULL + # t8_cmesh_destroy(Ref(cmesh)) + # end - cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) + # end - @assert cmesh==C_NULL "Expected fail of reading binary msh file v.4, but did not fail." + # @testset "test_msh_file_vers4_bin" begin + # fileprefix = "cmesh/testfiles/test_msh_file_vers4_bin" + # filename = fileprefix * ".msh" - if cmesh != C_NULL - t8_cmesh_destroy(Ref(cmesh)) - end - end + + # println("Hello 2!") + + # @assert isfile(filename) "File not found: "*filename + + # cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) + + # @assert cmesh==C_NULL "Expected fail of reading binary msh file v.4, but did not fail." + + # if cmesh != C_NULL + # t8_cmesh_destroy(Ref(cmesh)) + # end + # end end diff --git a/test/test_all.jl b/test/test_all.jl index 1b86d62..c093ac3 100644 --- a/test/test_all.jl +++ b/test/test_all.jl @@ -27,9 +27,9 @@ end include("test_forestwrapper.jl") end -# @testset "cmesh" begin -# include("cmesh/test_readmshfile.jl") -# end +@testset "cmesh" begin + include("cmesh/test_readmshfile.jl") +end @testset "forest" begin include("forest/test_element_volume.jl") From 75895e8444a1aad5e03eaee3a3cb4170bd4e00fb Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Tue, 20 May 2025 13:27:48 +0200 Subject: [PATCH 09/11] Test again --- test/cmesh/test_readmshfile.jl | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/cmesh/test_readmshfile.jl b/test/cmesh/test_readmshfile.jl index a0ecfaf..5e134ad 100644 --- a/test/cmesh/test_readmshfile.jl +++ b/test/cmesh/test_readmshfile.jl @@ -81,18 +81,12 @@ end t8_supported_msh_file(cmesh) t8_cmesh_destroy(Ref(cmesh)) - - - println("Hello 4!") end @testset "test_msh_file_vers4_ascii" begin fileprefix = "cmesh/testfiles/test_msh_file_vers4_ascii" filename = fileprefix * ".msh" - - println("Hello 3!") - @assert isfile(filename) "File not found: "*filename cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) @@ -100,13 +94,9 @@ end @assert cmesh!=C_NULL "Could not read cmesh from ascii version 4, but should be able to: "*filename t8_cmesh_destroy(Ref(cmesh)) - end # @testset "test_msh_file_vers2_bin" begin - - - # println("Hello!") # fileprefix = "cmesh/testfiles/test_msh_file_vers2_bin" # filename = fileprefix * ".msh" @@ -119,16 +109,12 @@ end # if cmesh != C_NULL # t8_cmesh_destroy(Ref(cmesh)) # end - # end # @testset "test_msh_file_vers4_bin" begin # fileprefix = "cmesh/testfiles/test_msh_file_vers4_bin" # filename = fileprefix * ".msh" - - # println("Hello 2!") - # @assert isfile(filename) "File not found: "*filename # cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) From e76725e5dabbd15b39c68c1c0579465a7345d932 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Wed, 21 May 2025 07:43:11 +0200 Subject: [PATCH 10/11] Deactivate cmesh case again --- test/test_all.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_all.jl b/test/test_all.jl index c093ac3..1b86d62 100644 --- a/test/test_all.jl +++ b/test/test_all.jl @@ -27,9 +27,9 @@ end include("test_forestwrapper.jl") end -@testset "cmesh" begin - include("cmesh/test_readmshfile.jl") -end +# @testset "cmesh" begin +# include("cmesh/test_readmshfile.jl") +# end @testset "forest" begin include("forest/test_element_volume.jl") From 9a2c7c7edec9aa42ec42e89e6c7201f624a9c751 Mon Sep 17 00:00:00 2001 From: Thomas Spenke Date: Mon, 1 Dec 2025 13:07:57 +0100 Subject: [PATCH 11/11] tmp commit -> do not push! --- test/cmesh/test_readmshfile.jl | 42 +++++++++++++++++----------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/test/cmesh/test_readmshfile.jl b/test/cmesh/test_readmshfile.jl index 5e134ad..5c4ea15 100644 --- a/test/cmesh/test_readmshfile.jl +++ b/test/cmesh/test_readmshfile.jl @@ -84,7 +84,7 @@ end end @testset "test_msh_file_vers4_ascii" begin - fileprefix = "cmesh/testfiles/test_msh_file_vers4_ascii" + fileprefix = "cmesh/testfiles/test_msh_file_vers4_ascii"S filename = fileprefix * ".msh" @assert isfile(filename) "File not found: "*filename @@ -96,33 +96,33 @@ end t8_cmesh_destroy(Ref(cmesh)) end - # @testset "test_msh_file_vers2_bin" begin - # fileprefix = "cmesh/testfiles/test_msh_file_vers2_bin" - # filename = fileprefix * ".msh" + @testset "test_msh_file_vers2_bin" begin + fileprefix = "cmesh/testfiles/test_msh_file_vers2_bin" + filename = fileprefix * ".msh" - # @assert isfile(filename) "File not found: "*filename + @assert isfile(filename) "File not found: "*filename - # cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) + cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) - # @assert cmesh==C_NULL "Expected fail of reading binary msh file v.2, but did not fail." + @assert cmesh==C_NULL "Expected fail of reading binary msh file v.2, but did not fail." - # if cmesh != C_NULL - # t8_cmesh_destroy(Ref(cmesh)) - # end - # end + if cmesh != C_NULL + t8_cmesh_destroy(Ref(cmesh)) + end + end - # @testset "test_msh_file_vers4_bin" begin - # fileprefix = "cmesh/testfiles/test_msh_file_vers4_bin" - # filename = fileprefix * ".msh" + @testset "test_msh_file_vers4_bin" begin + fileprefix = "cmesh/testfiles/test_msh_file_vers4_bin" + filename = fileprefix * ".msh" - # @assert isfile(filename) "File not found: "*filename + @assert isfile(filename) "File not found: "*filename - # cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) + cmesh = t8_cmesh_from_msh_file(fileprefix, 1, comm, 2, 0, 0) - # @assert cmesh==C_NULL "Expected fail of reading binary msh file v.4, but did not fail." + @assert cmesh==C_NULL "Expected fail of reading binary msh file v.4, but did not fail." - # if cmesh != C_NULL - # t8_cmesh_destroy(Ref(cmesh)) - # end - # end + if cmesh != C_NULL + t8_cmesh_destroy(Ref(cmesh)) + end + end end