Does the codecov check in the nightly even do anything?

[sandro-elsweijer]

Question

Our codecov tests for each pr the testing difference to main. But in the nightly suite there is nothing to compare.
I propose removing the codecov from the nightly suite and displaying the codecov from the last merged pr run as status, since this is the most recent reported coverage.

[Davknapp]

Yes, it checks the status between the status of the latest main and the current night, see this run: https://app.codecov.io/gh/DLR-AMR/t8code/commit/c1e6afc5abf8d8b46b03c1e21839df3f01c932ff for example. It compares c1e6afc which is the most recent commit of the day with 322342b, which was the status of main before.

[sandro-elsweijer]

This is exactly my point. It makes no sense to compute the difference to the last commit because this will always just be the diff of the last merged PR. Even if multiple PRs were merged since the last nighty. It is just a duplication of the run from the last merge queue of the day: https://app.codecov.io/gh/DLR-AMR/t8code/pull/2139?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=DLR-AMR

It is just a duplication

[Davknapp]

I am not sure of the behaviour if multiple merge-queues passed on a day. Does it really compare with the lateste merge queue, or does it compare with the version of main the day before? If it is the first case I agree with you, we can reuse the already known result.

[Davknapp]

@lenaploetzke is our codecov expert. Do you know the details to this question?

[lenaploetzke]

I would have to look into this more deeply. After a quick search, I couldn't figure out exactly how it works.