Merge pull request #1 from pwcnorthrop/pwcnorthrop-patch-1

BUG: _qmc.py::_random_oa_lhs produces correlated samples

Author: pwcnorthrop

scipy/stats/_qmc.py

@@ -1494,7 +1494,8 @@ def _random_oa_lhs(self, n: IntNumber = 4) -> np.ndarray:
         for j in range(n_col):
             perms = self.rng.permutation(p)
             oa_sample_[:, j] = perms[oa_sample[:, j]]
-
+        
+        oa_sample = oa_sample_
         # following is making a scrambled OA into an OA-LHS
         oa_lhs_sample = np.zeros(shape=(n_row, n_col))
         lhs_engine = LatinHypercube(d=1, scramble=self.scramble, strength=1,
@@ -1505,8 +1506,6 @@ def _random_oa_lhs(self, n: IntNumber = 4) -> np.ndarray:
                 lhs = lhs_engine.random(p).flatten()
                 oa_lhs_sample[:, j][idx] = lhs + oa_sample[:, j][idx]
 
-                lhs_engine = lhs_engine.reset()
-
         oa_lhs_sample /= p
 
         return oa_lhs_sample[:, :self.d]  # type: ignore