From fecea8702162b9f65d84464aaab84beb24d11466 Mon Sep 17 00:00:00 2001 From: Carles Capell Date: Thu, 6 Nov 2025 11:49:10 +0100 Subject: [PATCH 1/3] Revert flaky flag on Node.js Security Control test --- manifests/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifests/nodejs.yml b/manifests/nodejs.yml index d56ced81c1f..515e5d30568 100644 --- a/manifests/nodejs.yml +++ b/manifests/nodejs.yml @@ -514,7 +514,7 @@ tests/: test_security_controls.py: TestSecurityControls: '*': *ref_5_37_0 - fastify: flaky (APPSEC-58724) + fastify: *ref_5_61_0 nextjs: missing_feature rasp/: test_api10.py: From 6da97bc24d3d02c01a23bba28f822c25b05009e4 Mon Sep 17 00:00:00 2001 From: Carles Capell Date: Thu, 27 Nov 2025 11:02:47 +0100 Subject: [PATCH 2/3] Add flaky decorator to security controls test --- tests/appsec/iast/test_security_controls.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/appsec/iast/test_security_controls.py b/tests/appsec/iast/test_security_controls.py index 9d46a12cbb8..076acef361a 100644 --- a/tests/appsec/iast/test_security_controls.py +++ b/tests/appsec/iast/test_security_controls.py @@ -2,13 +2,14 @@ # This product includes software developed at Datadog (https://www.datadoghq.com/). # Copyright 2021 Datadog, Inc. -from utils import features, rfc, weblog, irrelevant +from utils import features, rfc, weblog, irrelevant, flaky from tests.appsec.iast.utils import BaseSinkTest, assert_iast_vulnerability, assert_metric from utils._weblog import HttpResponse @features.iast_security_controls @rfc("https://docs.google.com/document/d/1j1hp87-2wJnXUGADZxzLnvKJmaF_Gd6ZR1hPS3LVguQ/edit?pli=1&tab=t.0") +@flaky(context.library <= "nodejs@5.80" and context.weblog_variant == "fastify", reason="APPSEC-58724") class TestSecurityControls: @staticmethod def assert_iast_is_enabled(request: HttpResponse) -> None: From 2da969f39821ca7f2d442f85324519811247a341 Mon Sep 17 00:00:00 2001 From: Carles Capell Date: Thu, 27 Nov 2025 11:04:45 +0100 Subject: [PATCH 3/3] Fix import --- tests/appsec/iast/test_security_controls.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/appsec/iast/test_security_controls.py b/tests/appsec/iast/test_security_controls.py index 076acef361a..fc4caf1a271 100644 --- a/tests/appsec/iast/test_security_controls.py +++ b/tests/appsec/iast/test_security_controls.py @@ -2,7 +2,7 @@ # This product includes software developed at Datadog (https://www.datadoghq.com/). # Copyright 2021 Datadog, Inc. -from utils import features, rfc, weblog, irrelevant, flaky +from utils import features, rfc, weblog, irrelevant, flaky, context from tests.appsec.iast.utils import BaseSinkTest, assert_iast_vulnerability, assert_metric from utils._weblog import HttpResponse