Add cloning via DataContractSerializer and apply where it was already used

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Framework/Cloner.cs

@@ -29,5 +29,25 @@ public static T CloneViaBinarySerialization<T>(T source)
         return (T) Formatter.Deserialize(stream);
       }
     }
+
+    public static T CloneViaDataContractSerializer<T>(T source, IEnumerable<Type> knownTypes)
+    {
+      using (var mStream = new MemoryStream()) {
+        var dcSerializer = new DataContractSerializer(typeof(T), knownTypes);
+        dcSerializer.WriteObject(mStream, source);
+        _ = mStream.Seek(0, SeekOrigin.Begin);
+        return (T) dcSerializer.ReadObject(mStream);
+      }
+    }
+
+    public static T CloneViaDataContractSerializer<T>(T source, DataContractSerializerSettings settings)
+    {
+      using (var mStream = new MemoryStream()) {
+        var dcSerializer = new DataContractSerializer(typeof(T), settings);
+        dcSerializer.WriteObject(mStream, source);
+        _ = mStream.Seek(0, SeekOrigin.Begin);
+        return (T) dcSerializer.ReadObject(mStream);
+      }
+    }
   }
 }

Orm/Xtensive.Orm.Tests.Sql/MySQL/MiscTests.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2025 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Malisa Ncube
 // Created:    2011.03.17
 
@@ -68,14 +68,11 @@ public void ArrayTest()//TODO: Find reason why this pattern is structured like t
       SqlSelect select = SqlDml.Select();
       select.Where = SqlDml.In(1, i);
 
-      using (var mStream = new MemoryStream()) {
-        var dcSerializer = new DataContractSerializer(typeof(SqlSelect), [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
-        dcSerializer.WriteObject(mStream, select);
-        _ = mStream.Seek(0, SeekOrigin.Begin);
-        select = (SqlSelect) dcSerializer.ReadObject(mStream);
-      }
+      var cloned = Cloner.CloneViaDataContractSerializer(select, [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
 
       Console.WriteLine(SqlDriver.Compile(select).GetCommandText());
+      Console.WriteLine(SqlDriver.Compile(cloned).GetCommandText());
+
     }
 
     [Test]

Orm/Xtensive.Orm.Tests.Sql/SqlServer/MiscTests.cs

@@ -72,14 +72,10 @@ public void ArrayTest()
       SqlSelect select = SqlDml.Select();
       select.Where = SqlDml.In(1, i);
 
-      using(var mStream = new MemoryStream()) {
-        var dcSerializer = new DataContractSerializer(typeof(SqlSelect), [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
-        dcSerializer.WriteObject(mStream, select);
-        _ = mStream.Seek(0, SeekOrigin.Begin);
-        select = (SqlSelect) dcSerializer.ReadObject(mStream);
-      }
+      var cloned = Cloner.CloneViaDataContractSerializer(select, [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
 
       Console.WriteLine(sqlDriver.Compile(select).GetCommandText());
+      Console.WriteLine(sqlDriver.Compile(cloned).GetCommandText());
     }
 
     [Test]

Orm/Xtensive.Orm.Tests.Sql/Sqlite/MiscTests.cs

@@ -125,14 +125,10 @@ public void ArrayTest() //TODO: Find reason why this pattern is structured like
       SqlSelect select = SqlDml.Select();
       select.Where = SqlDml.In(1, i);
 
-      using(var mStream = new MemoryStream()) {
-        var dcSerializer = new DataContractSerializer(typeof(SqlSelect), [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
-        dcSerializer.WriteObject(mStream, select);
-        _ = mStream.Seek(0, SeekOrigin.Begin);
-        select = (SqlSelect) dcSerializer.ReadObject(mStream);
-      }
+      var cloned = Cloner.CloneViaDataContractSerializer(select, [typeof(SqlLiteral<int>), typeof(SqlBinary), typeof(SqlNative), typeof(SqlArray<int>)]);
 
       Console.WriteLine(sqlDriver.Compile(select).GetCommandText());
+      Console.WriteLine(sqlDriver.Compile(cloned).GetCommandText());
     }
 
     [Test]

Orm/Xtensive.Orm.Tests/Issues/Issue0808_StructSerialization.cs

@@ -51,18 +51,10 @@ public void MainTest()
       var t = typeof(UnifiedCustomerID);
       Expression<Func<int, UnifiedCustomerID>> ex = a => new UnifiedCustomerID { Id = 2 };
       var serializableExpression = ex.ToSerializableExpression();
-      using (var memoryStream = new MemoryStream()) {
-        var serializer = new DataContractSerializer(typeof(SerializableLambdaExpression),
-          SerializableExpressionTypes.Except(Enumerable.Repeat(typeof(SerializableLambdaExpression), 1)));
+      var deserializedExpression = (SerializableLambdaExpression) Cloner.CloneViaDataContractSerializer(serializableExpression,
+        SerializableExpressionTypes.Except(Enumerable.Repeat(typeof(SerializableLambdaExpression), 1)));
 
-        serializer.WriteObject(memoryStream, serializableExpression);
-
-        memoryStream.Position = 0;
-
-        var deserializedExpression = (SerializableLambdaExpression) serializer.ReadObject(memoryStream);
-
-        var ex2 = deserializedExpression.ToExpression();
-      }
+      var ex2 = deserializedExpression.ToExpression();
     }
   }
 }