Apply patches collected by Greg Roelofs

[DavidGriffith]

After the last official release of xv, Greg Roelofs has maintained the xv "Jumbo Patch" which incorporates all sorts of patches that he has collected. The last time the Jumbo Patch was updated was 2007. He recently sent me many individual patches that he hasn't assembled into a new Jumbo Patch. This is a listing of what was in the archive.

• xv-20040426-joe-zbiciak-rh7.3-bad-libpng.msg
• xv-20040525-jean-pierre-demailly-startgrab-imake-hips.patch
• xv-20040602-walter-harms-suse-rpm-specfile.msg
• xv-20041004-bruno-rohee-bmp-16bit-openbsd.patch.msg
• xv-20050422-joe-zonker-brockmeier-response-from-john-bradley.msg
• xv-20050601-jim-r-kirkpatrick-xvmisc.c-statement-not-reached.msg
• xv-20070625-thomas-klausner-bsd-compilation-issues.msg
• xv-20070711-fabian-greffrath-binaries-in-patch.msg
• xv-20071013-ross-combs-resize-ppos-paste.msg
• xv-20071013-ross-combs-resize-ppos-paste.patch
• xv-20071016-lukacs-arpad-gcc-4.x-lvalues-fix.patch
• xv-20071211-l-gabriel-somlo-response-from-john-bradley.msg
• xv-20080118-ian-collier-crash-fixes.msg
• xv-20080506-joe-peterson-wait-CLK_TCK-fix.dif
• xv-20080616-joe-peterson-makefile-LDFLAGS-to-linker.msg
• xv-20080901-david-bath-empty-filename-save-crash-fix.dif
• xv-20081204-fabian-greffrath-icon.xpm
• xv-20081204-fabian-greffrath-pixmap-manpage-bugs.mime
• xv-20081205-niklas-edmundsson-filename-buffersize-fix.patch
• xv-20081205-niklas-edmundsson-filename-buffersize-fix.patch.mime
• xv-20081211.klaus-ethgen-msg.pgp.txt
• xv-20081213-anthony-thyssen-slideshow-pause.dif
• xv-20081215-fabian-greffrath-xv.desktop.mime
• xv-20081216-elmar-plischke-xviff-crash-fix.dif
• xv-20081218-fabian-greffrath-01-cflags.patch
• xv-20081218-fabian-greffrath-02-shared-libjasper.patch
• xv-20081218-fabian-greffrath-03-install-pixmap.patch
• xv-20081218-fabian-greffrath-04-install-desktop.patch
• xv-20081218-fabian-greffrath-05-install-README.patch
• xv-20081218-fabian-greffrath-06-hyphen-used-as-minus-sign.patch
• xv-20081218-fabian-greffrath-07-manpages-CFLAGS-etc.mime
• xv-20081218-fabian-greffrath-patches-01-06.mime
• xv-20081227-klaus-ethgen-own-jumbo-patches-in-git.msg
• xv-20090126-ignatios-souvatzis-xxx.msg.pgp.asc
• xv-20090131-grr-C++-comments.where
• xv-20090322-jan-fuchs-CLOCKS_PER_SEC-vs-USE_TICKS.msg
• xv-20090426-lluis-perez-vidal-c++-comments-and-makefile.patch.mime
• xv-20090826-paul-howarth-warnings-and-JP-FLmask.patch.mime
• xv-20090907-patrick-keshishian-CMYK-JPEG-crash-fix.patch
• xv-20090907-patrick-keshishian-CMYK-JPEG-crash-fix.patch.mime
• xv-20090912-patrick-keshishian-CMYK-JPEG-crash-test-case.jpg
• xv-20090912-patrick-keshishian-CMYK-JPEG-crash-test-case.jpg.mime
• xv-20091212-patrick-keshishian-bmp-negative-height.patch.mime
• xv-20091215-werner-fink-multiple-fixes.patch.mime
• xv-20091217-patrick-keshishian-bmp-negative-height.patch.mime
• xv-20100206-niklas-edmundsson-filename-buffersize-fix2.patch
• xv-20100206-niklas-edmundsson-filename-buffersize-fix2.patch.mime
• xv-20100212-patrick-keshishian-bmp-negative-height.patch.mime
• xv-20100225-jpeg-segfault-bug-test-case.notes
• xv-20100228-anthony-thyssen-window-geometry-pos-drift.patch
• xv-20100405-patrick-keshishian-negative-height-sample.bmp.mime
• xv-20100523-markku-savela-wheelmouse-request.msg
• xv-20100523-ville-saari-clipboard-colormap-fix.dif
• xv-20100811-eeri-kask-nopos-window-placement-fix.patch
• xv-20110523-patrick-keshishian-openbsd-segfault-fix.msg
• xv-20110615-fabian-greffrath-libpng15-compile.msg
• xv-20120505-ross-combs-middle-button-paste.mime
• xv-20120507-ross-combs-middle-button-paste.mime
• xv-20130213-hints-for-macosx-snow-leopard.msgs
• xv-20130314-gabriel-somlo-NAME_MAX-buffer-overrun-fix.dif
• xv-20130328-gabriel-somlo-NAME_MAX-buffer-overrun-fix2.mark-brader-cut-paste-fix.dif
• xv-20140327-mark-brader-24bit-autocrop-bug.msg
• xv-20140506-yann-ricquebourg--exitcode.patch
• xv-20140506-yann-ricquebourg--newpng.patch
• xv-20140603-fabian-greffrath--updated-Debian-redistrib-permission.msg
• xv-20150913-rainer-m-canavan--xrandr-support--webp-support.dif
• xv--adobe-XMP--test-image--inspections_table_2013.png
• xv--adobe-XMP--test-image--inspections_table_2013.where
• xv--adobe-XMP--test-image--tumblr_mlqyn0H7A01qb3mfao1_250.png
• xv--adobe-XMP--test-image--tumblr_mlqyn0H7A01qb3mfao1_250.where
• xv-erling-jacobsen-20080225-smoothing-crash-fix.diff
• xv-fabian-greffrath-20070215-debian-stuff.msgs
• xv-fabian-greffrath-20070814-cygwin-patch.msg
• xv-fabian-greffrath-CFLAGS-fix2.diff
• xv-fabian-greffrath-CFLAGS-fix.diff
• xv-greg-kriehn-20071214-fedora8-packaging.msg
• xv-grr.dif.20070318.xvinfo-security-fix
• xv-jerome-ibanes-jpeg2000-2005-07-02T16-14-47-quality-100-truncate-eighth.jp2
• xv-jerome-ibanes-jpeg2000-output.gif
• xv-jerome-ibanes-jpeg2000-patches3.diff
• xv-jerome-ibanes-jpeg2000-patches.diff
• xv-jerome-ibanes-jpeg2000-patches.msg
• xv-jerome-ibanes-jpeg2000-patches.sh
• xv-joe-zbiciak-20070621-gif-decoder-bugfix.dif
• xv-jpdemailly-20070904-g3-fax-patch.mime
• xv-lukacs-arpad-gcc422-fix.dif
• xv-michal-maruska-no-flicker-bkgd.patch
• xv-rcombs-resize-ppos-paste.diff
• xv-rcombs-resize-ppos-paste.where
• xv-scott-marovich-20070214-jpeg2000-stuff.msgs
• xv-thomas-loimer-20070810-ubuntu-fixes.msg

[DavidGriffith]

xv-20040426-joe-zbiciak-rh7.3-bad-libpng.msg

The versions of libpng discussed are long obsolete. Leaving as-is

Greg,

One last rapid-fire email:

The LibPNG that comes with RedHat 7.3 doesn't seem to work well w/
XV 3.10a. I tried building xvicons for a directory full of images and
XV died with malloc failure in LoadPNG. I rebuilt/relinked against
a different LibPNG I installed when I upgraded GIMP and all was well.
(Since I'm not root on this system, the other LibPNG is in a separate
directory away from the system LibPNG.)

FWIW, the bad LibPNG is:

$ rpm -q libpng
libpng-1.0.14-0.7x.4

The working LibPNG is 1.2.5.

[DavidGriffith]

xv-20040525-jean-pierre-demailly-startgrab-imake-hips.patch

Adds a "-startgrab" option and adds support for an obscure format called HIPS. These additions made it into the 2007 Jumbo Patch. Also edits Imakefile to disable by default the included jpeg and tiff libraries. That did not make it into the Jumbo Patch. Frankly, it would be best to not do anything with imake anymore.

[DavidGriffith]

xv-20040602-walter-harms-suse-rpm-specfile.msg

Specfile stuff for making RPMs. Not relevant. At least not anymore.

[DavidGriffith]

xv-20041004-bruno-rohee-bmp-16bit-openbsd.patch.msg

References http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/graphics/xv/patches/Attic/patch-xvbmp_c which adds 16-bit support for BMP image files.

Incorporated into the 2007 Jumbo Patch.

[DavidGriffith]

xv-20050422-joe-zonker-brockmeier-response-from-john-bradley.msg

Commentary on correspondence from John Bradley.

[DavidGriffith]

xv-20050601-jim-r-kirkpatrick-xvmisc.c-statement-not-reached.msg

Something about "statement not reached" in xvmisc.c.

[DavidGriffith]

xv-20070625-thomas-klausner-bsd-compilation-issues.msg

Compilation problems with BSD. Fixes apparently in the 2007 Jumbo Patch.

[DavidGriffith]

xv-20070711-fabian-greffrath-binaries-in-patch.msg

Something about avoiding binaries in the Jumbo Patch. Probably nothing done with this.

[DavidGriffith]

xv-20071013-ross-combs-resize-ppos-paste.msg
xv-20071013-ross-combs-resize-ppos-paste.patch

Mentions xvselect.c, but the patch doesn't add it. Indeed, Greg doesn't seem to know where it is.

DID NOT appear in 2007 Jumbo Patch

• Patch to allow resizing of control and save/load windows.
• Middle-click paste support in the file selection box.
• Use of memcpy when memory doesn't overlap (slight speedup)
• Fix many cases where NULL was used in place of None
• some style stuff - whitespace, 0 -> FALSE, etc.

TODO

• Resize flickers because we don't use bit_gravity and smart redraws
• No select or copy support
• Try transient, group, and popup hints to see if placement can be made to work nicely everywhere without an option

I found the missing file. See Issue #8.

[DavidGriffith]

xv-20071016-lukacs-arpad-gcc-4.x-lvalues-fix.patch

Small patch to address problems about "generalized lvalues" being used in a way that was legal for gcc 3.x, but not 4.x. The problem seems to have been fixed by the time the 2007 Jumbo Patch came out.

[DavidGriffith]

xv-20071211-l-gabriel-somlo-response-from-john-bradley.msg

Commentary on correspondence from John Bradley.

[DavidGriffith]

xv-20080118-ian-collier-crash-fixes.msg

• "xv -root -quit foo.jpg" succeeds but always prints a BadWindow error message.
• crash when clicking around in the filename box for load/save windows.

Incorporated into the 2007 Jumbo Patch

[DavidGriffith]

xv-20080506-joe-peterson-wait-CLK_TCK-fix.dif

Use of CLK_TCK is obsolete as of POSIX.1-1996. This causes problems when using -wait.

NOT APPLIED

It probably should be added, though I want to know how this would affect machines that don't honor POSIX.1-1996.

Applied in 25683ef

[DavidGriffith]

xv-20080616-joe-peterson-makefile-LDFLAGS-to-linker.msg

Stuff about making sure that $(LDFLAGS) are on link lines in the Makefile. Mentions Gentoo patches which may be found here: https://gitweb.gentoo.org/repo/gentoo.git/tree/media-gfx/xv/files

Applied in 94fda99