Merge pull request #47 from WimDeMeester/master

Version 4.19.1

Author: WimDeMeester

changelog.md

@@ -2,6 +2,12 @@
 
 All notable changes to `laravel-astronomy-library` will be documented in this file.
 
+## Version 4.19.1
+
+### Changed
+
+- Obliquity is not needed as parameter in the calculateEquatorialCoordinates method of Planet and Elliptic
+
 ## Version 4.19
 
 ### Added

readme.md

@@ -437,16 +437,14 @@ $coords = $venus->calculateHeliocentricCoordinates($date);
 // Calculate the Equatorial Coordinates of Venus
 $date   = Carbon::create(1992, 12, 20, 0, 0, 0, 'UTC');
 $venus  = new Venus();
-$nutation = Time::nutation(Time::getJd($date));
-$venus->calculateEquatorialCoordinates($date, $nutation[3]);
+$venus->calculateEquatorialCoordinates($date);
 
 // Calculate the Equatorial Coordinates of comet Encke
 $date     = Carbon::create(1990, 10, 6, 0, 0, 0, 'UTC');
 $encke    = new Elliptic();
 $peridate = Carbon::create(1990, 10, 28, 13, 4, 50, 'UTC');
 $encke->setOrbitalElements(2.2091404, 0.8502196, 11.94524, 186.23352, 334.75006, $peridate);
-$nutation = Time::nutation(Time::getJd($date));
-$encke->calculateEquatorialCoordinates($date, $nutation[3]);
+$encke->calculateEquatorialCoordinates($date);
 ```
 
 ## Change log

src/deepskylog/AstronomyLibrary/Targets/Elliptic.php

@@ -70,24 +70,23 @@ public function setOrbitalElements(float $a, float $e, float $i, float $omega, f
      * Calculates the equatorial coordinates of the planet.
      *
      * @param Carbon $date      The date for which to calculate the coordinates
-     * @param float  $obliquity The obliquity of the ecliptic for the given date
      *
      * See chapter 33 of Astronomical Algorithms
      */
-    public function calculateEquatorialCoordinates(Carbon $date, float $obliquity): void
+    public function calculateEquatorialCoordinates(Carbon $date): void
     {
         $this->setEquatorialCoordinatesToday(
-            $this->_calculateEquatorialCoordinates($date, $obliquity)
+            $this->_calculateEquatorialCoordinates($date)
         );
         $this->setEquatorialCoordinatesTomorrow(
-            $this->_calculateEquatorialCoordinates($date->addDay(), $obliquity)
+            $this->_calculateEquatorialCoordinates($date->addDay())
         );
         $this->setEquatorialCoordinatesYesterday(
-            $this->_calculateEquatorialCoordinates($date->subDays(2), $obliquity)
+            $this->_calculateEquatorialCoordinates($date->subDays(2))
         );
     }
 
-    public function _calculateEquatorialCoordinates(Carbon $date, float $obliquity): EquatorialCoordinates
+    public function _calculateEquatorialCoordinates(Carbon $date): EquatorialCoordinates
     {
         $F = cos(deg2rad($this->_longitude_ascending_node));
         $G = sin(deg2rad($this->_longitude_ascending_node)) * 0.917482062;

src/deepskylog/AstronomyLibrary/Targets/Planet.php

@@ -42,24 +42,23 @@ public function __construct()
      * Calculates the equatorial coordinates of the planet.
      *
      * @param Carbon $date      The date for which to calculate the coordinates
-     * @param float  $obliquity The obliquity of the ecliptic for the given date
      *
      * See chapter 33 of Astronomical Algorithms
      */
-    public function calculateEquatorialCoordinates(Carbon $date, float $obliquity): void
+    public function calculateEquatorialCoordinates(Carbon $date): void
     {
         $this->setEquatorialCoordinatesToday(
-            $this->_calculateEquatorialCoordinates($date, $obliquity)
+            $this->_calculateEquatorialCoordinates($date)
         );
         $this->setEquatorialCoordinatesTomorrow(
-            $this->_calculateEquatorialCoordinates($date->addDay(), $obliquity)
+            $this->_calculateEquatorialCoordinates($date->addDay())
         );
         $this->setEquatorialCoordinatesYesterday(
-            $this->_calculateEquatorialCoordinates($date->subDays(2), $obliquity)
+            $this->_calculateEquatorialCoordinates($date->subDays(2))
         );
     }
 
-    public function _calculateEquatorialCoordinates(Carbon $date, float $obliquity): EquatorialCoordinates
+    public function _calculateEquatorialCoordinates(Carbon $date): EquatorialCoordinates
     {
         $helio_coords = $this->calculateHeliocentricCoordinates($date);