Skip to content

Conversation

@pacmancoder
Copy link
Contributor

No description provided.

@pacmancoder pacmancoder requested a review from Copilot November 11, 2025 12:13
@github-actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot finished reviewing on behalf of pacmancoder November 11, 2025 12:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a detached execution mode for the agent's process execution functionality, allowing fire-and-forget process launches without IO redirection or active session management.

Key changes:

  • Added run_detached() method to spawn processes that run independently without IO monitoring
  • Refactored WinApiProcessCtx to remove the stored io_notification_tx field, passing it as a parameter instead
  • Implemented console window hiding for all spawned processes (not just detached ones)

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
devolutions-session/src/dvc/task.rs Added detached mode handling in four message processors (exec_process, exec_batch, exec_winps, exec_pwsh), checking is_detached() flag and calling run_detached() instead of normal execution flow
devolutions-session/src/dvc/process.rs Refactored WinApiProcessCtx to pass io_notification_tx as parameter; added run_impl() and run_detached() methods; implemented console window hiding via SW_HIDE flag
devolutions-session/Cargo.toml Updated now-proto-pdu dependency to use git branch feat/exec-detached instead of crates.io version
Cargo.lock Updated lockfile with new now-proto-pdu version from git and resolved transitive dependency versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Nov 11, 2025

@pacmancoder I've opened a new pull request, #1568, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants