Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

Evaluate cleanup operations in Stop method of WAL #1763

@ayushsatyam146

Description

@ayushsatyam146

he Stop method of the walForge is responsible for gracefully shutting down the Write-Ahead Log component. It currently handles stopping internal tickers, canceling the context, syncing the current segment file to disk, and closing the file. However there might be additional cleanup operations missing, which could lead to resource leaks, unpersisted state, or an inconsistent system state upon shutdown or subsequent restart.
Refer below TODO in code

// TODO: See if we are missing any other cleanup operations.

Setup Instructions

  1. setup DiceDB server locally from the source - instructions
  2. setup DiceDB Go SDK locally from the source - instructions
  3. setup DiceDB CLI locally from the source - instructions
  4. refer to the Pointing to local checked-out dicedb-gosection inREADME`.

Start the DiceDB server

$ go run main.go --log-level debug

Follow the contribution guidelines

These are general guidelines to follow before you submit a patch. Please mark them as done once you complete them

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions