feat: command success/failure log (#18)

* Add a few more features for Administration logs

* fix arguments saying Unknown for commands with no arguments

* removed the NotFound feature

* spelling mistake fix

Co-authored-by: Lumi <me@jxtq.moe>

* spelling mistake fix #2

Co-authored-by: Lumi <me@jxtq.moe>

* Move around some config options to group related ones together

* Apply suggestion from @LumiFae

Co-authored-by: Lumi <me@jxtq.moe>

---------

Co-authored-by: Lumi <me@jxtq.moe>

Author: OMEGA3065

DiscordLab.Administration/Config.cs

@@ -21,6 +21,12 @@ public class Config
     [Description("The channel to send normal command logs")]
     public ulong CommandLogChannelId { get; set; } = 0;
 
+    [Description("Should a secondary translation be used for remote admin commands whose response is a failure?")]
+    public bool UseSecondaryTranslationRemoteAdmin { get; set; } = false;
+    
+    [Description("Should a secondary translation be used for normal commands whose response is a failure?")]
+    public bool UseSecondaryTranslationCommand { get; set; } = false;
+
     [Description("Whether to add the commands to the bot. Is false then commands won't be used.")]
     public bool AddCommands { get; set; } = true;
 }

DiscordLab.Administration/Events.cs

@@ -83,10 +83,12 @@ public override void OnServerCommandExecuted(CommandExecutedEventArgs ev)
         SocketTextChannel channel;
         TranslationBuilder builder = new TranslationBuilder("player", player)
             .AddCustomReplacer("type", ev.CommandType.ToString())
-            .AddCustomReplacer("arguments", () => string.Join(" ", ev.Arguments))
+            .AddCustomReplacer("arguments", () => !ev.Arguments.Any() ? " " : string.Join(" ", ev.Arguments))
             .AddCustomReplacer("command", ev.CommandName)
-            .AddCustomReplacer("commanddescription", () => ev.Command.Description ?? "Unknown");
+            .AddCustomReplacer("commanddescription", () => ev.Command.Description ?? "Unknown")
+            .AddCustomReplacer("commandsuccess", () => ev.ExecutedSuccessfully ? "Yes" : "No");
 
+        MessageContent translation;
         if (ev.CommandType == CommandType.RemoteAdmin)
         {
             if (Config.RemoteAdminChannelId == 0)
@@ -98,8 +100,9 @@ public override void OnServerCommandExecuted(CommandExecutedEventArgs ev)
                     Config.RemoteAdminChannelId, Config.GuildId));
                 return;
             }
-
-            Translation.RemoteAdmin.SendToChannel(channel, builder);
+            
+            translation = Config.UseSecondaryTranslationRemoteAdmin && !ev.ExecutedSuccessfully ? Translation.RemoteAdminCommandFailResponse : Translation.RemoteAdmin;
+            translation.SendToChannel(channel, builder);
             return;
         }
 
@@ -112,7 +115,8 @@ public override void OnServerCommandExecuted(CommandExecutedEventArgs ev)
                 Config.GuildId));
             return;
         }
-
-        Translation.CommandLog.SendToChannel(channel, builder);
+        
+        translation = Config.UseSecondaryTranslationCommand && !ev.ExecutedSuccessfully ? Translation.CommandLogFailResponse : Translation.CommandLog;
+        translation.SendToChannel(channel, builder);
     }
 }

DiscordLab.Administration/Translation.cs

@@ -14,6 +14,11 @@ public class Translation
         "Player {player} has executed the remote admin command: `{command}`";
 
     public MessageContent CommandLog { get; set; } = "Player {player} has executed the command: `{command}`";
+    
+    public MessageContent RemoteAdminCommandFailResponse { get; set; } =
+        "Player {player} has attempted to run a remote admin command which failed: `{command}`";
+
+    public MessageContent CommandLogFailResponse { get; set; } = "Player {player} has attempted to run a command which failed: `{command}`";
 
     public string SendCommandName { get; set; } = "send";