Skip to content

Fix value handling for enums #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitryTsepelev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix value handling for enums #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

## master

- [PR #205](https://github.com/DmitryTsepelev/store_model/pull/205) Fix value handling for enums ([@DmitryTsepelev])

## 4.2.1 (2025-02-01)

- [PR #200](https://github.com/DmitryTsepelev/store_model/pull/200) Don't use #to_h on store model instances in OnePolymorphic types ([@23tux])
Expand Down
5 changes: 4 additions & 1 deletion lib/store_model/types/enum_type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ def cast_value(value)
private

def cast_symbol_value(value)
raise_invalid_value!(value) if @raise_on_invalid_values && !@mapping.key?(value.to_sym)
raise_invalid_value!(value) if @raise_on_invalid_values &&
!@mapping.key?(value.to_sym) &&
!@mapping.values.include?(value)

@mapping[value.to_sym] || value
end

Expand Down
32 changes: 32 additions & 0 deletions spec/store_model/enum_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,4 +249,36 @@ def self.model_name
end
end
end

describe "persistance" do
class ProductConfiguration
include StoreModel::Model

enum :color, in: { red: "ee0000", green: "00ee00", blue: "0000ee" }
end

class Product < ActiveRecord::Base
attribute :product_configuration, ProductConfiguration.to_type, default: ProductConfiguration.new
end

before do
Product.create!(product_configuration: { color: color })
end

context "when key is used" do
let(:color) { :green }

specify do
expect(Product.last.product_configuration).to be_green
end
end

context "when value is used" do
let(:color) { "00ee00" }

specify do
expect(Product.last.product_configuration).to be_green
end
end
end
end
Loading