-
Notifications
You must be signed in to change notification settings - Fork 54
Add Verifiable Message Signing #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update the client SDKs under sdk/. It is also recommended to add a corresponding Verify() API as a counterpart to Sign().
Co-authored-by: Kevin Wang <wy721@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much! We can merge it after the conflicts are resolved.
|
@kvinwang, fixed all the conflicts. |
|
@iKapitonau Could you take a look at the test failures? |
|
@kvinwang, done. Please re-run all checks. |
No description provided.