Merge pull request #230 from EasyPost/robust_tests

chore: better test coverage and enforcement

Author: Justintime50

.github/workflows/ci.yml

@@ -32,6 +32,6 @@ jobs:
       - name: Install Dependencies
         run: make install
       - name: Run Tests
-        run: EASYPOST_TEST_API_KEY=123 EASYPOST_PROD_API_KEY=123 make test
+        run: EASYPOST_TEST_API_KEY=123 EASYPOST_PROD_API_KEY=123 make coverage
       - name: Run security analysis
         run: make scan

Makefile

@@ -19,7 +19,7 @@ clean:
 
 ## coverage - Test the project and generate an HTML coverage report
 coverage:
-	$(VIRTUAL_BIN)/pytest --cov=$(PROJECT_NAME) --cov-branch --cov-report=html --cov-report=term-missing
+	$(VIRTUAL_BIN)/pytest --cov=$(PROJECT_NAME) --cov-branch --cov-report=html --cov-report=term-missing --cov-fail-under=88
 
 ## black - Runs the Black Python formatter against the project
 black:

easypost/address.py

@@ -44,24 +44,12 @@ def create_and_verify(cls, api_key: Optional[str] = None, **params) -> "Address"
         wrapped_params = {cls.snakecase_name(): params}
         response, api_key = requestor.request(method=RequestMethod.POST, url=url, params=wrapped_params)
 
-        response_address = response.get("address", None)
-
-        if response_address is not None:
-            verified_address = convert_to_easypost_object(response=response_address, api_key=api_key)
-            return verified_address
-        else:
-            return convert_to_easypost_object(response=response, api_key=api_key)
+        return convert_to_easypost_object(response=response["address"], api_key=api_key)
 
     def verify(self) -> "Address":
         """Verify an address."""
         requestor = Requestor(local_api_key=self._api_key)
         url = "%s/%s" % (self.instance_url(), "verify")
         response, api_key = requestor.request(method=RequestMethod.GET, url=url)
 
-        response_address = response.get("address", None)
-
-        if response_address is not None:
-            verified_address = convert_to_easypost_object(response=response_address, api_key=api_key)
-            return verified_address
-        else:
-            return convert_to_easypost_object(response=response, api_key=api_key)
+        return convert_to_easypost_object(response=response["address"], api_key=api_key)

easypost/endshipper.py

@@ -22,7 +22,10 @@ def create(cls, api_key: Optional[str] = None, **params) -> "EndShipper":
         return convert_to_easypost_object(response=response, api_key=api_key)
 
     def save(self) -> "EndShipper":
-        """Update an EndShipper object."""
+        """Update an EndShipper object.
+
+        This function requires all parameters to be present for an EndShipper.
+        """
         if self._unsaved_values:
             requestor = Requestor(local_api_key=self._api_key)
             params = {}

easypost/resource.py

@@ -17,9 +17,6 @@
 
 
 class Resource(EasyPostObject):
-    def _ident(self) -> List[str]:
-        return [self.get("id")]
-
     @classmethod
     def retrieve(cls, easypost_id: str, api_key: Optional[str] = None, **params) -> object:
         """Retrieve an object from the EasyPost API."""

easypost/version.py

@@ -1,8 +1,4 @@
 VERSION = "7.6.0"
 
-elements = VERSION.split("-")
-numbers = [str(v) for v in elements[0].split(".")]
-if len(elements) > 1:
-    numbers.extend(elements[1])
-numbers.extend(elements[1:])
+numbers = [str(number) for number in VERSION.split(".")]
 VERSION_INFO = numbers