Skip to content

Conversation

@cmygeHm
Copy link

@cmygeHm cmygeHm commented Apr 19, 2021

  1. It's not so useful to initialize client with string configuration keys, as your examples:
    $configuration = new \ElasticEmailClient\ApiConfiguration([
        'apiUrl' => 'https://api.elasticemail.com/v2/',
        'apiKey' => 'yourApiKey'
    ]);

More useful:

    $configuration = new \ElasticEmailClient\ApiConfiguration([
        \ElasticEmailClient\ApiConfiguration::API_URL => 'https://api.elasticemail.com/v2/',
        \ElasticEmailClient\ApiConfiguration::API_KEY => 'yourApiKey'
    ]);
  1. I think it is better to pass this options via setters and not to do them as required arguments of constructor:
$config = new ApiConfiguration();
$config
            ->setApiUrl($apiUrl)
            ->setApiKey($api);

If you do not agree with me I can remove this commit 478eb73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant