From ee005f5a499d36e9c5a49c07f4882293c411643b Mon Sep 17 00:00:00 2001 From: Chris Thielen Date: Wed, 23 Jan 2019 11:50:16 -0800 Subject: [PATCH] Fix angularChainableNames check This conditional was always `true` because `(name !== -1)` is always `true` and thus `angularChainableNames.indexOf(true)` is always `true` --- rules/utils/angular-rule.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/utils/angular-rule.js b/rules/utils/angular-rule.js index 5e731cb0..82f48c44 100644 --- a/rules/utils/angular-rule.js +++ b/rules/utils/angular-rule.js @@ -141,7 +141,7 @@ function angularRule(ruleDefinition) { // angular.module() // ^^^^^^ angularModuleCalls.push(callExpressionNode); - } else if (angularChainableNames.indexOf(callee.property.name !== -1) && (angularModuleCalls.indexOf(callee.object) !== -1 || angularChainables.indexOf(callee.object) !== -1)) { + } else if (angularChainableNames.indexOf(callee.property.name) !== -1 && (angularModuleCalls.indexOf(callee.object) !== -1 || angularChainables.indexOf(callee.object) !== -1)) { // angular.module().factory().controller() // ^^^^^^^ ^^^^^^^^^^ angularChainables.push(callExpressionNode);