add preferred local alias fix

Author: xuhuanzy

crates/emmylua_code_analysis/src/diagnostic/checker/code_style/preferred_local_alias.rs

@@ -5,6 +5,7 @@ use emmylua_parser::{
     LuaSyntaxKind,
 };
 use rowan::{NodeOrToken, TextRange};
+use serde_json::json;
 
 use crate::{
     DiagnosticCode, LuaDeclId, LuaSemanticDeclId, SemanticDeclLevel, SemanticModel,
@@ -247,7 +248,9 @@ fn check_index_expr_preference(
                 name = alias_info.preferred_name
             )
             .to_string(),
-            None,
+            Some(json!({
+                "preferredAlias": alias_info.preferred_name.clone(),
+            })),
         );
     }
 

crates/emmylua_ls/locales/action/zh_CN.yaml

@@ -19,3 +19,6 @@ Do you want to modify the require path?: |
 
 Modify: |
   修改
+
+Replace with local alias '%{name}': |
+  替换为本地变量别名 '%{name}'

crates/emmylua_ls/src/handlers/code_actions/actions/build_fix_code.rs

@@ -75,3 +75,29 @@ pub fn build_add_doc_tag(
 
     Some(())
 }
+
+pub fn build_preferred_local_alias_fix(
+    semantic_model: &SemanticModel,
+    actions: &mut Vec<CodeActionOrCommand>,
+    range: Range,
+    data: &Option<serde_json::Value>,
+) -> Option<()> {
+    let alias_name = data.as_ref()?.get("preferredAlias")?.as_str()?;
+    let document = semantic_model.get_document();
+    let text_edit = TextEdit {
+        range,
+        new_text: alias_name.to_string(),
+    };
+
+    actions.push(CodeActionOrCommand::CodeAction(CodeAction {
+        title: t!("Replace with local alias '%{name}'", name = alias_name).to_string(),
+        kind: Some(CodeActionKind::QUICKFIX),
+        edit: Some(WorkspaceEdit {
+            changes: Some(HashMap::from([(document.get_uri(), vec![text_edit])])),
+            ..Default::default()
+        }),
+        ..Default::default()
+    }));
+
+    Some(())
+}

crates/emmylua_ls/src/handlers/code_actions/build_actions.rs

@@ -8,11 +8,9 @@ use lsp_types::{
 
 use super::actions::{
     build_add_doc_tag, build_disable_file_changes, build_disable_next_line_changes,
+    build_need_check_nil, build_preferred_local_alias_fix,
 };
-use crate::handlers::{
-    code_actions::actions::build_need_check_nil,
-    command::{DisableAction, make_disable_code_command},
-};
+use crate::handlers::command::{DisableAction, make_disable_code_command};
 
 pub fn build_actions(
     semantic_model: &SemanticModel,
@@ -71,6 +69,9 @@ fn add_fix_code_action(
     match diagnostic_code {
         DiagnosticCode::NeedCheckNil => build_need_check_nil(semantic_model, actions, range, data),
         DiagnosticCode::UnknownDocTag => build_add_doc_tag(semantic_model, actions, range, data),
+        DiagnosticCode::PreferredLocalAlias => {
+            build_preferred_local_alias_fix(semantic_model, actions, range, data)
+        }
         _ => Some(()),
     }
 }