Skip to content

[Fix] Allow navigation to be spoken when device is on silent #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: v.next
Choose a base branch
from
Open

[Fix] Allow navigation to be spoken when device is on silent #729

wants to merge 12 commits into from

Conversation

@chriswebb09
Copy link
Collaborator

@chriswebb09 chriswebb09 commented Nov 20, 2025

Description

This is a fix so that the sample speaks navigation instructions when the device is on silent

Linked Issue(s)

  • swift/issues/7556

@chriswebb09 chriswebb09 self-assigned this Nov 20, 2025
@chriswebb09 chriswebb09 marked this pull request as ready for review November 24, 2025 18:13
yo1995
yo1995 reviewed Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an iOS 26 device.
Is this problem reproducible on iOS 26 Simulator? I turned on silent mode on simulator, and with or without the fix, the voice guidance are both announced.

@des12437
Copy link
Contributor

des12437 commented Nov 24, 2025

I don't have an iOS 26 device. Is this problem reproducible on iOS 26 Simulator? I turned on silent mode on simulator, and with or without the fix, the voice guidance are both announced.

I tested this on an iOS 26 device and without the fix the directions are not spoken when the device is on silent mode, with the fix the directions are spoken regardless.

@chriswebb09 chriswebb09 requested a review from des12437 November 25, 2025 19:41
des12437
des12437 reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation directions are also spoken in the Augment reality to navigate route so that sample should have this fix applied as well.

chriswebb09 and others added 2 commits November 25, 2025 13:32
@chriswebb09 @des12437
Update Shared/Samples/Navigate route/NavigateRouteView.swift
1198079 
Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@chriswebb09
update for comments
fd5d574
yo1995
yo1995 reviewed Nov 26, 2025
View reviewed changes
@chriswebb09 chriswebb09 requested a review from yo1995 November 27, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@des12437 des12437 Awaiting requested review from des12437

@yo1995 yo1995 Awaiting requested review from yo1995

At least 2 approving reviews are required to merge this pull request.

Assignees

@chriswebb09 chriswebb09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chriswebb09 @des12437 @yo1995