Fixed a bug where isEndOfStream would not work correctly for BinaryReaders created from Uint8Array, which had non-zero byte offset or smaller length than the underlaying buffer

Author: EvidentlyCube

src/BinaryReader.ts

@@ -53,7 +53,7 @@ export class BinaryReader
 	 */
 	public get isEndOfStream(): boolean
 	{
-		return this._position >= this._stream.byteLength;
+		return this._position >= this._bufferLength;
 	}
 
 	private get internalPosition(): number

test/BinaryReader.misc.common.test.ts

@@ -83,5 +83,13 @@ describe("BinaryReader, common tests", () =>
 			const reader = new BinaryReader(getBufferOfLength(0));
 			expect(reader.isEndOfStream).to.equal(true);
 		});
+		it("Should return true when at the end of stream that has data outside the view", () =>
+		{
+			const buffer = new ArrayBuffer(16);
+			const view = new Uint8Array(buffer, 4, 8);
+			const reader = new BinaryReader(view);
+			reader.position = 8;
+			expect(reader.isEndOfStream).to.equal(true);
+		});
 	});
 });