[Awaiting Checklist] [Payment due 2025-12-11] [$250] Expense - Inconsistent app redirection when new report is created

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.28-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1221/folder/13176730/41237110/941908457
Email or phone of affected tester (no customers): sdionjsdoisjdos@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account
3. Create a workspace
4. Go to Inbox
5. Open FAB > Create report
   → The new report is created on Inbox
6. Create two more workspaces
7. Delete the default workspace
8. Go to Inbox
9. Open FAB > Create report
10. Select any workspace
    → The new report is created on Reports

Expected Result:

In Step 5 and 7, the new report should be created on the same tab

Actual Result:

In Step 5, when there is a default workspace, the new report is created on Inbox
In Step 7, when there is no default workspace and there are at least two non-default workspaces, the new report is created on Reports

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6969701_1760015753567.Screen_Recording_2025-10-09_at_21.09.13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021976350477909073408
• Upwork Job ID: 1976350477909073408
• Last Price Increase: 2025-10-09
• Automatic offers:
• etCoderDysto | Contributor | 109134249

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Inconsistent app redirection when new report is created

What is the root cause of that problem?

When we create a report from NewReportWorkspaceSelectionPage, we are not checking if we are creating the report from search(Report) page

App/src/pages/NewReportWorkspaceSelectionPage.tsx

Lines 72 to 73 in f50b779

	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: optimisticReportID}), {forceReplace: isRHPOnReportInSearch || shouldUseNarrowLayout});

What changes do you think we should make in order to solve the problem?

We should check if we are creating the report from search page using isSearchTopmostFullScreenRoute, and navigate to search page when it is only true

 Navigation.navigate(
           isSearchTopmostFullScreenRoute() ? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: optimisticReportID}) : ROUTES.REPORT_WITH_ID.getRoute(optimisticReportID),
                    {forceReplace: isRHPOnReportInSearch || shouldUseNarrowLayout},
                );

We can pass the current route as backTo param for both navigations if we find it be necessary using Navigation.getActiveRoute()
Optional implementation with bakckTo param

code

 isSearchTopmostFullScreenRoute()
                        ? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: optimisticReportID, backTo: Navigation.getActiveRoute()})
                        : ROUTES.REPORT_WITH_ID.getRoute(optimisticReportID, Navigation.getActiveRoute()),
                    {forceReplace: isRHPOnReportInSearch || shouldUseNarrowLayout},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

none

What alternative solutions did you explore? (Optional)

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Inconsistent app redirection when new report is created

What is the root cause of that problem?

When creating a report from the Search page (when a default workspace is available), the FAB was using isSearchTopmostFullScreenRoute() to determine the navigation route, which caused it to navigate to ROUTES.SEARCH_MONEY_REQUEST_REPORT (Reports tab) instead of maintaining consistent behavior.

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 505 to 512 in f0f2b05

	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(
	isSearchTopmostFullScreenRoute()
	? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()})
	: ROUTES.REPORT_WITH_ID.getRoute(createdReportID, undefined, undefined, Navigation.getActiveRoute()),
	{forceReplace: isReportInSearch},
	);
	});

What changes do you think we should make in order to solve the problem?

Removed the conditional logic and now always navigates to ROUTES.REPORT_WITH_ID (Inbox tab) when creating reports

                                      Navigation.navigate(
                                          ROUTES.REPORT_WITH_ID.getRoute(createdReportID, undefined, undefined, Navigation.getActiveRoute()),
                                          {forceReplace: isReportInSearch},
                                      );

We should check other places such as NewReportWorkspaceSelectionPage,... vv. if it has this issue and fix it as well

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021976350477909073408

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[dangrous]

Happy to handle internal review on this when ready!