Expense - "Change workspace" option is shown in offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.95-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78423
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Login with new gmail account
3. Create 2 new workspaces
4. Go to workflows - Toggle off add approvals & payments in first workspace
5. Open workspace chat
6. Create 2 track expense
7. Turn off internet
8. Delete second workspace
9. Go to workspace chat
10. Tap submit
11. Open report and click on More

Expected Result:

"Change workspace" option must not be shown.

Actual Result:

"Change workspace" option is shown in offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Change workspace" option is shown in offline.

What is the root cause of that problem?

isWorkspaceEligibleForReportChange still returns true for pending delete policy:

App/src/libs/ReportUtils.ts

Lines 12248 to 12256 in a0bb986

	function isWorkspaceEligibleForReportChange(submitterEmail: string | undefined, newPolicy: OnyxEntry<Policy>, report?: Report): boolean {
	if (!submitterEmail || !newPolicy?.isPolicyExpenseChatEnabled) {
	return false;
	}
	if (report && report.stateNum === CONST.REPORT.STATE_NUM.APPROVED && report.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && !isPolicyAdminPolicyUtils(newPolicy)) {
	return false;
	}
	return isPaidGroupPolicyPolicyUtils(newPolicy) && !!newPolicy.role;
	}

What changes do you think we should make in order to solve the problem?

We should update isWorkspaceEligibleForReportChange to return false if policy is pending delete

return isPaidGroupPolicyPolicyUtils(newPolicy) && !!newPolicy.role && !isPendingDeletePolicy(newPolicy);

App/src/libs/ReportUtils.ts

Line 12255 in a0bb986

return isPaidGroupPolicyPolicyUtils(newPolicy) && !!newPolicy.role;

What alternative solutions did you explore? (Optional)

We can also use logics similar to useWorkspaceList

App/src/hooks/useWorkspaceList.ts

Lines 32 to 38 in a0bb986

	.filter(
	(policy) =>
	!!policy &&
	shouldShowPolicy(policy, shouldShowPendingDeletePolicy, currentUserLogin) &&
	!policy?.isJoinRequestPending &&
	(additionalFilter ? additionalFilter(policy) : true),
	)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - "Change workspace" option is shown in offline

What is the root cause of that problem?

isChangeWorkspaceAction filters policies using isWorkspaceEligibleForReportChange, but neither function checks if a policy has a pending delete action

App/src/libs/ReportSecondaryActionUtils.ts

Line 535 in a938a24

const availablePolicies = Object.values(policies ?? {}).filter((newPolicy) => isWorkspaceEligibleForReportChange(submitterEmail, newPolicy, report));

What changes do you think we should make in order to solve the problem?

We should filter out policies with pending delete action when building the availablePolicies list in isChangeWorkspaceAction

    const availablePolicies = Object.values(policies ?? {}).filter((newPolicy) => isWorkspaceEligibleForReportChange(submitterEmail, newPolicy, report) && !isPendingDeletePolicy(newPolicy));

App/src/libs/ReportSecondaryActionUtils.ts

Line 535 in a938a24

const availablePolicies = Object.values(policies ?? {}).filter((newPolicy) => isWorkspaceEligibleForReportChange(submitterEmail, newPolicy, report));

What alternative solutions did you explore? (Optional)

None

[twinkle-react]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Change workspace" option is shown in offline mode for reports when it should not be, because the option includes workspaces that are pending deletion.

What is the root cause of that problem?

The isChangeWorkspaceAction function in ReportSecondaryActionUtils.ts filters available policies using isWorkspaceEligibleForReportChange, but does not account for policies that are pending deletion. When a workspace is deleted while offline, it remains in the policies collection but should not be shown as an option for changing workspace.

What changes do you think we should make in order to solve the problem?

Add isPendingDeletePolicy to the PolicyUtils import and modify the policy filtering in isChangeWorkspaceAction to exclude pending delete policies:

import {
    // ... existing imports ...
    isPendingDeletePolicy,
    // ... existing imports ...
} from './PolicyUtils';

function isChangeWorkspaceAction(
    report: Report,
    policies: OnyxCollection<Policy>,
    reportActions?: ReportAction[]
): boolean {
    const submitterEmail = getLoginByAccountID(
        report?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID
    );

    const availablePolicies = Object.values(policies ?? {}).filter(
        (newPolicy) =>
            isWorkspaceEligibleForReportChange(submitterEmail, newPolicy) &&
            !isPendingDeletePolicy(newPolicy)
    );

    // ... rest of function unchanged ...
}

[yatin-italy]

Proposal

Please re-state the problem that we are trying to solve in this issue:
"Change workspace" option is shown in offline mode for reports when it should not be, because the option includes workspaces that are pending deletion.

What is the root cause of that problem?
The isChangeWorkspaceAction function filters policies for eligibility but doesn't exclude policies that are pending deletion.
When a workspace is deleted offline, it remains in the policies collection and gets included in the available options list, causing the "Change workspace" menu item to appear inappropriately.

What changes do you think we should make in order to solve the problem?
Add shouldShowPolicy to the PolicyUtils import and modify the policy filtering in isChangeWorkspaceAction to use shouldShowPolicy with shouldShowPendingDeletePolicy = false:

import {
    // ... existing imports ...
    shouldShowPolicy,
    // ... existing imports ...
} from './PolicyUtils';

function isChangeWorkspaceAction(
    report: Report,
    policies: OnyxCollection<Policy>,
    reportActions?: ReportAction[]
): boolean {
    const submitterEmail = getLoginByAccountID(report?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID);

    const availablePolicies = Object.values(policies ?? {})
        .filter((policy) => shouldShowPolicy(policy, false, submitterEmail))
        .filter((policy) => isWorkspaceEligibleForReportChange(submitterEmail, policy));

    // ... rest of function unchanged ...
}

What alternative solutions did you explore? (Optional)
NONE