Skip to content

Allow generated http clients that inherit from HttpClientService to call SendRequestAsync. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejball merged 2 commits into from
Oct 14, 2025
Merged

Allow generated http clients that inherit from HttpClientService to call SendRequestAsync. #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
962fb1e
Allow generated http clients that inherit from HttpClientService to c…
chrisculy Oct 14, 2025
b54a5b3
Publish 2.37.0
chrisculy Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<VersionPrefix>2.36.0</VersionPrefix>
<VersionPrefix>2.37.0</VersionPrefix>
<PackageValidationBaselineVersion>2.35.0</PackageValidationBaselineVersion>
<LangVersion>13.0</LangVersion>
<Nullable>enable</Nullable>
Expand Down
4 changes: 4 additions & 0 deletions ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes

## 2.37.0

* Allow generated http clients that inherit from HttpClientService to call SendRequestAsync.

## 2.36.0

* Allow generated http clients that inherit from HttpClientService to access the underlying HttpClient.
Expand Down
2 changes: 1 addition & 1 deletion src/Facility.Core/Http/HttpClientService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ protected virtual bool ShouldCreateErrorFromException(Exception exception)
/// </summary>
protected virtual Task RequestReadyAsync(HttpRequestMessage httpRequest, ServiceDto requestDto, CancellationToken cancellationToken) => Task.CompletedTask;

private async Task<HttpResponseMessage> SendRequestAsync(HttpRequestMessage httpRequest, ServiceDto requestDto, CancellationToken cancellationToken)
protected async Task<HttpResponseMessage> SendRequestAsync(HttpRequestMessage httpRequest, ServiceDto requestDto, CancellationToken cancellationToken)
{
await AdaptTask(RequestReadyAsync(httpRequest, requestDto, cancellationToken)).ConfigureAwait(true);

Expand Down