Use Boost.Process v2 API

[dennisklein]

A current spack build spack install fairmq fails due to Boost 1.88:

  >> 79    FAILED: fairmq/CMakeFiles/FairMQ.dir/shmem/Manager.cxx.o
     80    /home/dklein/projects/spack/opt/spack/linux-zen3/compiler-wrapper-1.0-j6bbh4f7t36qeqf46e36lgvgvqibxbgo/libexec/spack/gcc/g++ -DBOOST_ASIO_HAS_HAS_STD_CHRONO -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_FI
           LESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DFAIRLOGGER_USE_BOOST_PRETTY_FUNCTION -DFAIRM
           Q_CHANNEL_DEFAULT_AUTOBIND=true -DFAIRMQ_HAS_STD_FILESYSTEM=1 -DFAIRMQ_HAS_STD_PMR=1 -DFairMQ_EXPORTS -I/tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq -I/tmp/dklein/spack-stage/spack-stage-fai
           rmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src -I/tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-build-2cqfexb -isystem /home/dklein/projects/spack/opt/spack/linux-zen3/boost-1.88.0-sjpd22e24j6bwol5
           vjyf3ocjckgnhb4n/include -isystem /home/dklein/projects/spack/opt/spack/linux-zen3/fairlogger-1.11.1-rdpp3m5u3e3hvzlqfdyxutznz5bddd5c/include -isystem /home/dklein/projects/spack/opt/spack/linux-zen3/fmt-11.2.0-wsedkdoawnef6fsjq4mr2myu6phrnapk/
           include -isystem /home/dklein/projects/spack/opt/spack/linux-zen3/libzmq-4.3.5-uohewzurhjiaxrcegi2zovjvft4cdsxi/include -isystem /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/extern/PicoSHA2 -fdiagn
           ostics-color=never -O3 -g -Wshadow -Wall -Wextra -Wpedantic -DNDEBUG  -std=c++17 -fPIC -MD -MT fairmq/CMakeFiles/FairMQ.dir/shmem/Manager.cxx.o -MF fairmq/CMakeFiles/FairMQ.dir/shmem/Manager.cxx.o.d -o fairmq/CMakeFiles/FairMQ.dir/shmem/Manager
           .cxx.o -c /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx
     81    /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx: In static member function 'static bool fair::mq::shmem::Manager::SpawnShmMonitor(const std::string&)':
  >> 82    /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx:21:27: error: 'boost::this_process' has not been declared
     83       21 |     auto const env(boost::this_process::environment());
     84          |                           ^~~~~~~~~~~~
  >> 85    /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx:25:22: error: 'boost::this_process' has not been declared
     86       25 |     auto path(boost::this_process::path());
     87          |                      ^~~~~~~~~~~~
  >> 88    /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx:31:30: error: 'search_path' is not a member of 'boost::process'
     89       31 |     auto exe(boost::process::search_path(shmmonitor_exe_name, path));
     90          |                              ^~~~~~~~~~~
  >> 91    /tmp/dklein/spack-stage/spack-stage-fairmq-1.9.1-2cqfexbxhfw5twijqo4gqm2cysmxuimn/spack-src/fairmq/shmem/Manager.cxx:42:21: error: 'spawn' is not a member of 'boost::process'
     92       42 |     boost::process::spawn(
     93          |                     ^~~~~
     94    ninja: build stopped: subcommand failed.

spack install fairmq ^boost@1.87 works for me.

[dennisklein]

boostorg/process#480

• #define BOOST_PROCESS_VERSION=1 keeps boost::process pointing to api v1
• Otherwise, there is boost::process::v1 and boost::process::v2 while v2 is now default

--- a/var/spack/repos/spack_repo/builtin/packages/fairmq/package.py
+++ b/var/spack/repos/spack_repo/builtin/packages/fairmq/package.py
@@ -66,6 +66,7 @@ def cmake_args(self):
             self.define("BUILD_TESTING", self.run_tests),
             self.define_from_variant("BUILD_EXAMPLES", "examples"),
             self.define_from_variant("FAIRMQ_CHANNEL_DEFAULT_AUTOBIND", "autobind"),
+            self.define("CMAKE_CXX_FLAGS", "-DBOOST_PROCESS_VERSION=1"),
         ]
         if self.spec.variants["cxxstd"].value != "default":
             args.append(self.define_from_variant("CMAKE_CXX_STANDARD", "cxxstd"))

Would be a solution on pkg level, however, we should add a fix in FairMQ as well. edit: Tried. Does not fix it entirely.

[dennisklein]

spack/spack#50546 for now

[dennisklein]

@ktf Will you need this soon? Is it worth combining with #532?

[ktf]

@dennisklein only if you manage to support v1.83 and v1.88 at the same time. Otherwise it's a mess to adopt in production.

@silverweed this is actually the issue we had today.

[dennisklein]

#536

going to fix it these days

[dennisklein]

https://github.com/FairRootGroup/FairMQ/releases/tag/v1.10.1 adds support for Boost 1.89+.

[dennisklein]

Keeping this issue as a todo to switch to the Boost.Process v2 API. This change will need a breaking release and will bump the minimally required Boost to 1.80+ (Process v2 API only available since then).

[ktf]

Boost > 1.80 is fine for us. That said, I was wondering if it makes sense to rely so much on boost for trivialities like getting the environment or starting a process.