optimized ResourceController, fixed autosave in CKEditor, error views

Author: Famaxis

app/Http/Controllers/Frontend/ResourceController.php

@@ -9,27 +9,27 @@
 class ResourceController extends Controller
 {
     // is requested slug relevant to post or page?
-    public function show($request)
+    public function show($slug)
     {
-        if (Post::where('slug', $request)->exists()) {
-            $resource = Post::where('slug', $request)
-                ->with('tagged')
-                ->withCount('comments')
-                ->first();
+        $resource = Post::where('slug', $slug)
+            ->with('tagged')
+            ->withCount('comments')
+            ->first();
+        if ($resource) {
             return $this->showPost($resource);
         }
 
-        if (Page::where('slug', $request)->exists()) {
-            $resource = Page::where('slug', $request)
-                ->first();
+        $resource = Page::where('slug', $slug)
+            ->first();
+        if ($resource) {
             return $this->showPage($resource);
         }
 
         // if there is no resource with that slug
-        return abort('404');
+        abort('404');
     }
 
-    public function showPost($resource)
+    private function showPost($resource)
     {
         $next = Post::select(['slug'])
             ->where('id', '>', $resource->id)
@@ -41,29 +41,28 @@ public function showPost($resource)
             ->published()
             ->latest('id')
             ->first();
-
         $comments = $resource->comments()
             ->with('user')
             ->paginate(50)
             ->onEachSide(1);
 
         // view for custom template
         if ($resource->custom_template) {
-            return view('frontend.posts.single-custom', compact('resource','comments', 'next', 'prev'));
+            return view('frontend.posts.single-custom', compact('resource', 'comments', 'next', 'prev'));
         }
         // view for default template
-        return view('frontend.posts.single', compact('resource','comments','next', 'prev'));
+        return view('frontend.posts.single', compact('resource', 'comments', 'next', 'prev'));
     }
 
-    public function showPage($resource)
+    private function showPage($resource)
     {
         // view for custom template
         if ($resource->custom_template) {
             // for common templates
             $next = null;
             $prev = null;
             $comments = null;
-            return view('frontend.pages.single-custom', compact('resource','comments', 'next', 'prev'));
+            return view('frontend.pages.single-custom', compact('resource', 'comments', 'next', 'prev'));
         }
         // view for default template
         return view('frontend.pages.single', compact('resource'));

app/Http/Controllers/Frontend/SearchController.php

@@ -19,7 +19,7 @@ public function search(Request $request)
             if ($posts) {
                 foreach ($posts as $post) {
                     $output .=
-                        '<a href="' . route('front.resource.show',$post->slug) . '">
+                        '<a href="' . route('front.resource.show', $post->slug) . '">
                                 <div class="search-item padding-small">' . $post->first_sentence . '</div>
                             </a>';
                 }

app/Http/Middleware/Authenticate.php

@@ -16,7 +16,7 @@ protected function redirectTo($request)
     {
         if (! $request->expectsJson()) {
 //          // guests should not know admin's urls
-            return abort(404);
+            abort(404);
         }
     }
 }

public/ckeditor/config.js

@@ -50,7 +50,7 @@ CKEDITOR.editorConfig = function( config ) {
 	// Autosave
 	config.autosave = {
 		messageType : "no",
-		delay : 1,
+		delay : 0,
 		autoLoad: true,
 		saveOnDestroy : true,
 		// saveDetectionSelectors : "a[href^='javascript:__doPostBack'][id*='Save'],a[id*='Cancel']",

resources/views/errors/401.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>401</h1>
             <p>Unauthorized.</p>
         </div>
-
     </div>
-</div>
 @endsection

resources/views/errors/403.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>403</h1>
             <p>Forbidden.</p>
         </div>
-
     </div>
-</div>
 @endsection

resources/views/errors/404.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>404</h1>
             <p>This page doesn't exist.</p>
         </div>
-
     </div>
-</div>
 @endsection

resources/views/errors/419.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>419</h1>
             <p>Page expired.</p>
         </div>
-
     </div>
-</div>
 @endsection

resources/views/errors/500.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>500</h1>
             <p>Server error.</p>
         </div>
-
     </div>
-</div>
 @endsection

resources/views/errors/503.blade.php

@@ -1,13 +1,10 @@
 @extends('layouts.frontend')
 
 @section('content')
-<div class="container ">
     <div class="row flex-center">
         <div>
             <h1>503</h1>
             <p>Service Unavailable.</p>
         </div>
-
     </div>
-</div>
 @endsection