feat: add librdkafka log handler #660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imalexoff
force-pushed
the
feature/librdkafka-log-handler
branch
from
2a2b5fa to
02f3865
Compare
brmagadutra
force-pushed
the
feature/librdkafka-log-handler
branch
from
02f3865 to
e08cc91
Compare
BLage
reviewed
Dec 4, 2025
| logHandler.Verbose(message, data); | ||
| break; | ||
| default: | ||
| throw new ArgumentOutOfRangeException(nameof(logMessage.Level), logMessage.Level, null); |
There was a problem hiding this comment.
don't think it is worth throwing an exception because of log messages.
IMO if log level is not known it should fallback to DEBUG, while there is no evolution on this switch to support it.
Author
There was a problem hiding this comment.
I agree with you, but then it seems to me that if a level arrives that your code doesn't recognize, that's unusual by itself. Logging it as Debug or Verbose hides it among "noise". Therefore, I would use a Warning is more likely to show up in monitoring, alerts, and dashboards. You will notice faster that the system received an unexpected level.
imalexoff
force-pushed
the
feature/librdkafka-log-handler
branch
from
e08cc91 to
0af5592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a log handler to prevent writing to stderr for the producer, consumer and admin client. Also added mapping of
SyslogLevelto the correspondingLogHandlerlevel.Fixes #658
How Has This Been Tested?
Manual tests.
Checklist