Skip to content
This repository was archived by the owner on Feb 24, 2024. It is now read-only.

Commit 718cff8

Browse files
committed
Refactor CLI tests
Replace all usages of readFile with fs.readFileSync in CLI module tests. This function shouldn't be used as a helper in tests because it's a part of parse module and if its implementation will change in the future, it can have impact on results of those tests.
1 parent 6b444ae commit 718cff8

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

test/unit/cli/Cli.test.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import os from "os";
33
import {Writable} from "stream";
44
import Cli from "../../../src/cli/Cli";
55
import CliError, {ErrorCode} from "../../../src/cli/CliError";
6-
import {readFile} from "../../../src/parse/utils";
6+
7+
const fileEncoding = "utf-8";
78

89
describe("Parse incorrect arguments", () => {
910
const notExistingInputFile = "nonExistingFile.cpp";
@@ -48,15 +49,15 @@ describe("Parse correct arguments", () => {
4849
const output = new StringWritableStream();
4950
const cli = new Cli(output);
5051
cli.run([]);
51-
const helpText = readFile(helpFilePath);
52+
const helpText = fs.readFileSync(helpFilePath, fileEncoding);
5253
expect(output.data).toBe(helpText);
5354
});
5455

5556
test("When --help is passed, then help text is displayed on stdout", () => {
5657
const output = new StringWritableStream();
5758
const cli = new Cli(output);
5859
cli.run(["--help"]);
59-
const helpText = readFile(helpFilePath);
60+
const helpText = fs.readFileSync(helpFilePath, fileEncoding);
6061
expect(output.data).toBe(helpText);
6162
});
6263

@@ -65,7 +66,7 @@ describe("Parse correct arguments", () => {
6566
const output = new StringWritableStream();
6667
const cli = new Cli(output);
6768
cli.run(args);
68-
const expected = readFile(`${dataDirectory}/expected.cpp`);
69+
const expected = fs.readFileSync(`${dataDirectory}/expected.cpp`, fileEncoding);
6970
expect(output.data).toStrictEqual(expected);
7071
});
7172

@@ -75,8 +76,8 @@ describe("Parse correct arguments", () => {
7576
const args = ["-i", includeDirectory, "-s", sourceDirectory, "-o", outputFilePath, inputFilePath];
7677
const cli = new Cli();
7778
cli.run(args);
78-
const output = readFile(outputFilePath);
79-
const expected = readFile(`${dataDirectory}/expected.cpp`);
79+
const output = fs.readFileSync(outputFilePath, fileEncoding);
80+
const expected = fs.readFileSync(`${dataDirectory}/expected.cpp`, fileEncoding);
8081
expect(output).toStrictEqual(expected);
8182
});
8283

@@ -86,8 +87,8 @@ describe("Parse correct arguments", () => {
8687
const args = ["-i", includeDirectory, "-s", sourceDirectory, "--output", outputFilePath, inputFilePath];
8788
const cli = new Cli();
8889
cli.run(args);
89-
const output = readFile(outputFilePath);
90-
const expected = readFile(`${dataDirectory}/expected.cpp`);
90+
const output = fs.readFileSync(outputFilePath, fileEncoding);
91+
const expected = fs.readFileSync(`${dataDirectory}/expected.cpp`, fileEncoding);
9192
expect(output).toStrictEqual(expected);
9293
});
9394
});

0 commit comments

Comments
 (0)